From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B0DDC3A5A4 for ; Tue, 27 Aug 2019 08:03:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40E04206BA for ; Tue, 27 Aug 2019 08:03:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566892997; bh=dyjZHILtQTS0ehIpD3DGAVTw3m4jcFLb84TCYisqpdU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=swpdOtE4RUK5Tb5b2oUDuj9qBvY+9UtZZ0LsI4+a3ATmuaVjTarEq5aNxxJpf5xM/ YMIFBRqUVa0LuRx1K9zKEFCzz/or1a9eMPLDKelFMYyKAGQUvGpqLJ6xCFtbFGAhV7 mfZGEikl5IvMHT48jiKyvPpG+b+P7d4o3K7OKKQc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732221AbfH0IDK (ORCPT ); Tue, 27 Aug 2019 04:03:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:60550 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732213AbfH0IDK (ORCPT ); Tue, 27 Aug 2019 04:03:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AD4F42184D; Tue, 27 Aug 2019 08:03:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566892989; bh=dyjZHILtQTS0ehIpD3DGAVTw3m4jcFLb84TCYisqpdU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y/0YEeKHhkRpEGf8uUgPi/6pveJX8HgurArPZLJjdPzYtWh7Rcn5kRsE7IkRw6/xW gJGYZlnNda5/TVBNiMWnIQnQGRSrgdcsgpK53aB1+lFCXJEvNI1fJzsqs0DSrRgubJ X6oSJNITDegYs1crLBdTroKRqckkJkvfbZMo9QrE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nick Kralevich , Suren Baghdasaryan , "Peter Zijlstra (Intel)" , lizefan@huawei.com, mingo@redhat.com, akpm@linux-foundation.org, kernel-team@android.com, dennisszhou@gmail.com, dennis@kernel.org, hannes@cmpxchg.org, axboe@kernel.dk, Sasha Levin Subject: [PATCH 5.2 084/162] sched/psi: Do not require setsched permission from the trigger creator Date: Tue, 27 Aug 2019 09:50:12 +0200 Message-Id: <20190827072741.055271779@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190827072738.093683223@linuxfoundation.org> References: <20190827072738.093683223@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 04e048cf09d7b5fc995817cdc5ae1acd4482429c ] When a process creates a new trigger by writing into /proc/pressure/* files, permissions to write such a file should be used to determine whether the process is allowed to do so or not. Current implementation would also require such a process to have setsched capability. Setting of psi trigger thread's scheduling policy is an implementation detail and should not be exposed to the user level. Remove the permission check by using _nocheck version of the function. Suggested-by: Nick Kralevich Signed-off-by: Suren Baghdasaryan Signed-off-by: Peter Zijlstra (Intel) Cc: lizefan@huawei.com Cc: mingo@redhat.com Cc: akpm@linux-foundation.org Cc: kernel-team@android.com Cc: dennisszhou@gmail.com Cc: dennis@kernel.org Cc: hannes@cmpxchg.org Cc: axboe@kernel.dk Link: https://lkml.kernel.org/r/20190730013310.162367-1-surenb@google.com Signed-off-by: Sasha Levin --- kernel/sched/psi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c index 7fe2c5fd26b54..23fbbcc414d5d 100644 --- a/kernel/sched/psi.c +++ b/kernel/sched/psi.c @@ -1061,7 +1061,7 @@ struct psi_trigger *psi_trigger_create(struct psi_group *group, mutex_unlock(&group->trigger_lock); return ERR_CAST(kworker); } - sched_setscheduler(kworker->task, SCHED_FIFO, ¶m); + sched_setscheduler_nocheck(kworker->task, SCHED_FIFO, ¶m); kthread_init_delayed_work(&group->poll_work, psi_poll_work); rcu_assign_pointer(group->poll_kworker, kworker); -- 2.20.1