From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7768C3A5A1 for ; Wed, 28 Aug 2019 14:54:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7BDF22CF5 for ; Wed, 28 Aug 2019 14:54:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567004087; bh=nRoVnyXH44/etg5pMU0NDrZDAiJeLE0X5uYHQ9ZtS4E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fwmvKRf+t7AX9leA2YxFf/OWjjbB6L9sF3BZD2IOXYN8IZvxEWPP4Thgq/Rqtt09y Q860twqwR0/cPbb+6IktiHbyL5qv1EsF9iCjXo/rzkHeANp9lzPEg6pN5/jmcXiD2c EP2XeM8cigW//M4MmiOmE8Rums9HlA7PihHO2hnw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726450AbfH1Oyr (ORCPT ); Wed, 28 Aug 2019 10:54:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:47228 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726315AbfH1Oyr (ORCPT ); Wed, 28 Aug 2019 10:54:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3F4052189D; Wed, 28 Aug 2019 14:54:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567004085; bh=nRoVnyXH44/etg5pMU0NDrZDAiJeLE0X5uYHQ9ZtS4E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QvJ9tqZMgA0wROFUXMfZZRi6JwBGMVNPMKUlm9OkvhmcCHd4KTWhrS/IiAfAJSQ4N NC768dKN1kdmuUf9gn42kofcZYx9DeZ2C2HqTd/H3lZlLsa7l+C+N9xsHSdrVwSVJ7 7FRXDCpOTcbLVsW+e/n5jXaJJFxZHEYFd1d56lPg= Date: Wed, 28 Aug 2019 16:54:43 +0200 From: Greg Kroah-Hartman To: Guenter Roeck Cc: Sasha Levin , stable@vger.kernel.org Subject: Re: Patches potentially missing from stable releases Message-ID: <20190828145443.GA7974@kroah.com> References: <20190827171621.GA30360@roeck-us.net> <20190827181003.GR5281@sasha-vm> <20190827200151.GA19618@roeck-us.net> <20190827202901.GB1118@kroah.com> <20190827204841.GA21062@roeck-us.net> <20190828084107.GB29927@kroah.com> <1ff990c8-3ea8-5f8b-78b6-d1d91da9e508@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1ff990c8-3ea8-5f8b-78b6-d1d91da9e508@roeck-us.net> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Aug 28, 2019 at 06:43:43AM -0700, Guenter Roeck wrote: > On 8/28/19 1:41 AM, Greg Kroah-Hartman wrote: > > On Tue, Aug 27, 2019 at 01:48:41PM -0700, Guenter Roeck wrote: > > > On Tue, Aug 27, 2019 at 10:29:01PM +0200, Greg Kroah-Hartman wrote: > > > > On Tue, Aug 27, 2019 at 01:01:51PM -0700, Guenter Roeck wrote: > > > > > On Tue, Aug 27, 2019 at 02:10:03PM -0400, Sasha Levin wrote: > > > > > > On Tue, Aug 27, 2019 at 10:16:21AM -0700, Guenter Roeck wrote: > > > > > > > Hi, > > > > > > > > > > > > > > I recently wrote a script which identifies patches potentially missing > > > > > > > in downstream kernel branches. The idea is to identify patches backported/ > > > > > > > applied to a downstream branch for which patches tagged with Fixes: are > > > > > > > available in the upstream kernel, but those fixes are missing from the > > > > > > > downstream branch. The script workflow is something like: > > > > > > > > > > > > > > - Identify locally applied patches in downstream branch > > > > > > > - For each patch, identify the matching upstream SHA > > > > > > > - Search the upstream kernel for Fixes: tags with this SHA > > > > > > > - If one or more patches with matching Fixes: tags are found, check > > > > > > > if the patch was applied to the downstream branch. > > > > > > > - If the patch was not applied to the downstream branch, report > > > > > > > > > > > > > > Running this script on chromeos-4.19 identified, not surprisingly, a number > > > > > > > of such patches. However, and more surprisingly, it also identified several > > > > > > > patches applied to v4.19.y for which fixes are available in the upstream > > > > > > > kernel, but those fixes have not been applied to v4.19.y. Some of those > > > > > > > are on the cosmetic side, but several seem to be relevant. I didn't > > > > > > > cross-check all of them, but the ones I tried did apply to linux-4.19.y. > > > > > > > The complete list is attached below. > > > > > > > > > > > > > > Question: Do Sasha's automated scripts identify such patches ? If not, > > > > > > > would it make sense to do it ? Or is there some reason why the patches > > > > > > > have not been applied to v4.19.y ? > > > > > > > > > > > > Hey Guenter, > > > > > > > > > > > > I have a very similar script with a slight difference: I don't try to > > > > > > find just "Fixes:" tags, but rather just any reference from one patch to > > > > > > another. This tends to catch cases where once patch states it's "a > > > > > > similar fix to ..." and such. > > > > > > > > > > > > The tricky part is that it's causing a whole bunch of false positives, > > > > > > which takes a while to weed through - and that's where the issue is > > > > > > right now. > > > > > > > > > > > > > > > > I didn't see any false positives, at least not yet. Would it possibly > > > > > make sense to start with looking at Fixes: ? After all, additional > > > > > references (wich higher chance for false positives) can always be > > > > > searched for later. > > > > > > > > I used to do this "by hand" with a tiny bit of automation, but need to > > > > step it up and do it "correctly" like you did. > > > > > > > > If you have a pointer to your script, I'd be glad to run it here locally > > > > to keep track of this, like I do so for patches tagged with syzbot > > > > issues. > > > > > > > > > > I'd have to rewrite it to work with stable branches. Its current > > > primary goal is to assist the rebase of one chromeos branch to > > > a later upstream kernel release. I just repurposed part of it and > > > use the generated databases to identify patches tagged with Fixes:. > > > > > > I'll be happy to do that and make it work on stable branches in > > > general if you think it would add value. > > > > No worries, I can add the functionality to my local scripts that I have. > > If you just had happened to have it in stand-alone format, it would have > > saved me 30 minutes or so :) > > > > I'll do it anyway. Already almost done. You are apparently better than me, > though. It takes me a bit more than 30 minutes, but then I am using the > opportunity to improve the scripts a bit. I'll publish the whole thing > at github once complete. I'm not saying it would be 30 minutes "from scratch", as I already have most of this all working already as I am doing this today for the syzbot stuff: https://github.com/gregkh/gregkh-linux/blob/master/scripts/syzbot_search A "real" script would be wonderful to have, thanks! thanks, greg k-h