From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FF7EC3A59F for ; Thu, 29 Aug 2019 18:22:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B80221726 for ; Thu, 29 Aug 2019 18:22:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567102962; bh=oLrqx1jVZX6DMZtILp4heemXD3Tol8v0lg65undTA/c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LYxO+AwHNO0X0Z0m/vOQUywpVzyr5E/gfkn8PFlWgq3n+om8PcvtW25ZuAQjNH31+ IHkIyQcyxq8/43lvfX2sp63z0m3/rgwi30gH1ay2xxy78kHvgLC4EngpmVxLEp/yWZ 9YlBOywOntfyUvukiasyuBaTu9sYM/c5X4eDG8Ns= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728900AbfH2SWl (ORCPT ); Thu, 29 Aug 2019 14:22:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:59318 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729982AbfH2SRK (ORCPT ); Thu, 29 Aug 2019 14:17:10 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 484EE23403; Thu, 29 Aug 2019 18:17:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567102629; bh=oLrqx1jVZX6DMZtILp4heemXD3Tol8v0lg65undTA/c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V/I4iceKEQebF996WwziBfaKvloxC/t8MmwrQ7AE/AZezG0LyTUllDlWvzTD6Gs73 wr53/T/TAE9czRI9ta8Twq1f1mlDqPr/NXxYvlWLnISyrX26e4f4CpC8zKsN4jLyRz JHa5bZp+2bODs9sE+hMdOnpeQHxXroDRPyEdhhx8= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wenwen Wang , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 10/27] cxgb4: fix a memory leak bug Date: Thu, 29 Aug 2019 14:16:36 -0400 Message-Id: <20190829181655.8741-10-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190829181655.8741-1-sashal@kernel.org> References: <20190829181655.8741-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Wenwen Wang [ Upstream commit c554336efa9bbc28d6ec14efbee3c7d63c61a34f ] In blocked_fl_write(), 't' is not deallocated if bitmap_parse_user() fails, leading to a memory leak bug. To fix this issue, free t before returning the error. Signed-off-by: Wenwen Wang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c index 76540b0e082d3..9e5cd18e7358c 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c @@ -2777,8 +2777,10 @@ static ssize_t blocked_fl_write(struct file *filp, const char __user *ubuf, return -ENOMEM; err = bitmap_parse_user(ubuf, count, t, adap->sge.egr_sz); - if (err) + if (err) { + kvfree(t); return err; + } bitmap_copy(adap->sge.blocked_fl, t, adap->sge.egr_sz); kvfree(t); -- 2.20.1