[PATCH] drm: mst: Fix query_payload ack reply struct

[PATCH] drm: mst: Fix query_payload ack reply struct

[Sean Paul]

From: Sean Paul <seanpaul@chromium.org>

Spec says[1] Allocated_PBN is 16 bits

[1]- DisplayPort 1.2 Spec, Section 2.11.9.8, Table 2-98

Fixes: ad7f8a1f9ced ("drm/helper: add Displayport multi-stream helper (v0.6)")
Cc: Lyude Paul <lyude@redhat.com>
Cc: Todd Previte <tprevite@gmail.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Sean Paul <sean@poorly.run>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v3.17+
Signed-off-by: Sean Paul <seanpaul@chromium.org>
---
 include/drm/drm_dp_mst_helper.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/drm_dp_mst_helper.h b/include/drm/drm_dp_mst_helper.h
index 2ba6253ea6d3..fc349204a71b 100644
--- a/include/drm/drm_dp_mst_helper.h
+++ b/include/drm/drm_dp_mst_helper.h
@@ -334,7 +334,7 @@ struct drm_dp_resource_status_notify {
 
 struct drm_dp_query_payload_ack_reply {
 	u8 port_number;
-	u8 allocated_pbn;
+	u16 allocated_pbn;
 };
 
 struct drm_dp_sideband_msg_req_body {
-- 
Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] drm: mst: Fix query_payload ack reply struct

[Lyude Paul]

Is it worth actually CCing stable on this? This patch is certainly correct but
I don't think we use this struct for anything quite yet.

Otherwise: Reviewed-by: Lyude Paul <lyude@redhat.com>

On Thu, 2019-08-29 at 12:52 -0400, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
> 
> Spec says[1] Allocated_PBN is 16 bits
> 
> [1]- DisplayPort 1.2 Spec, Section 2.11.9.8, Table 2-98
> 
> Fixes: ad7f8a1f9ced ("drm/helper: add Displayport multi-stream helper
> (v0.6)")
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Todd Previte <tprevite@gmail.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Cc: <stable@vger.kernel.org> # v3.17+
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
>  include/drm/drm_dp_mst_helper.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/drm/drm_dp_mst_helper.h
> b/include/drm/drm_dp_mst_helper.h
> index 2ba6253ea6d3..fc349204a71b 100644
> --- a/include/drm/drm_dp_mst_helper.h
> +++ b/include/drm/drm_dp_mst_helper.h
> @@ -334,7 +334,7 @@ struct drm_dp_resource_status_notify {
>  
>  struct drm_dp_query_payload_ack_reply {
>  	u8 port_number;
> -	u8 allocated_pbn;
> +	u16 allocated_pbn;
>  };
>  
>  struct drm_dp_sideband_msg_req_body {
-- 
Cheers,
	Lyude Paul

Re: [PATCH] drm: mst: Fix query_payload ack reply struct

[Sean Paul]

On Thu, Aug 29, 2019 at 01:06:58PM -0400, Lyude Paul wrote:
> Is it worth actually CCing stable on this? This patch is certainly correct but
> I don't think we use this struct for anything quite yet.
> 
> Otherwise: Reviewed-by: Lyude Paul <lyude@redhat.com>

Thanks for the review! I've stripped the cc stable tag and pushed to
drm-misc-next. We'll have to keep an eye out for Sasha's stable AI bot, I'm
guessing it'll try to backport this to stable regardless.

Sean

> 
> On Thu, 2019-08-29 at 12:52 -0400, Sean Paul wrote:
> > From: Sean Paul <seanpaul@chromium.org>
> > 
> > Spec says[1] Allocated_PBN is 16 bits
> > 
> > [1]- DisplayPort 1.2 Spec, Section 2.11.9.8, Table 2-98
> > 
> > Fixes: ad7f8a1f9ced ("drm/helper: add Displayport multi-stream helper
> > (v0.6)")
> > Cc: Lyude Paul <lyude@redhat.com>
> > Cc: Todd Previte <tprevite@gmail.com>
> > Cc: Dave Airlie <airlied@redhat.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> > Cc: Sean Paul <sean@poorly.run>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: <stable@vger.kernel.org> # v3.17+
> > Signed-off-by: Sean Paul <seanpaul@chromium.org>
> > ---
> >  include/drm/drm_dp_mst_helper.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/drm/drm_dp_mst_helper.h
> > b/include/drm/drm_dp_mst_helper.h
> > index 2ba6253ea6d3..fc349204a71b 100644
> > --- a/include/drm/drm_dp_mst_helper.h
> > +++ b/include/drm/drm_dp_mst_helper.h
> > @@ -334,7 +334,7 @@ struct drm_dp_resource_status_notify {
> >  
> >  struct drm_dp_query_payload_ack_reply {
> >  	u8 port_number;
> > -	u8 allocated_pbn;
> > +	u16 allocated_pbn;
> >  };
> >  
> >  struct drm_dp_sideband_msg_req_body {
> -- 
> Cheers,
> 	Lyude Paul
> 

-- 
Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] drm: mst: Fix query_payload ack reply struct

[Sasha Levin]

On Thu, Aug 29, 2019 at 02:44:15PM -0400, Sean Paul wrote:
>On Thu, Aug 29, 2019 at 01:06:58PM -0400, Lyude Paul wrote:
>> Is it worth actually CCing stable on this? This patch is certainly correct but
>> I don't think we use this struct for anything quite yet.
>>
>> Otherwise: Reviewed-by: Lyude Paul <lyude@redhat.com>
>
>Thanks for the review! I've stripped the cc stable tag and pushed to
>drm-misc-next. We'll have to keep an eye out for Sasha's stable AI bot, I'm
>guessing it'll try to backport this to stable regardless.

Knowing the bot, it probably will :)

I'll add a note for myself...

--
Thanks,
Sasha