From: Greg KH <greg@kroah.com>
To: "François Valenduc" <francoisvalenduc@gmail.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Jiri Slaby <jslaby@suse.cz>,
stable@vger.kernel.org, henryburns@google.com,
sergey.senozhatsky@gmail.com,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: Kernel 5.2.11 dpes not compile
Date: Mon, 2 Sep 2019 20:07:38 +0200 [thread overview]
Message-ID: <20190902180738.GA17333@kroah.com> (raw)
In-Reply-To: <0d340d5b-5495-c66f-eff3-b12c016ed927@gmail.com>
On Mon, Sep 02, 2019 at 08:01:45PM +0200, François Valenduc wrote:
>
> Le 29/08/19 à 14:32, Sergey Senozhatsky a écrit :
> > On (08/29/19 14:28), Jiri Slaby wrote:
> > [..]
> >> as is its definition in the structure (and its other uses).
> >>
> >>> ./include/linux/wait.h:67:26: note: in definition of macro ‘init_waitqueue_head’
> >>> __init_waitqueue_head((wq_head), #wq_head, &__key); \
> >>> ^~~~~~~
> >>> scripts/Makefile.build:278: recipe for target 'mm/zsmalloc.o' failed
> >>> make[1]: *** [mm/zsmalloc.o] Error 1
> >>> Makefile:1073: recipe for target 'mm' failed
> >>>
> >>> You can find my configuration file attached.
> >> You forgot to attach it, but you have CONFIG_COMPACTION=n, I assume.
> >>
> >>> Does anybody have any idea about this ?
> >> Sure, this will fix it (or turn on compaction):
> >> --- a/mm/zsmalloc.c
> >> +++ b/mm/zsmalloc.c
> >> @@ -2413,7 +2413,9 @@ struct zs_pool *zs_create_pool(const char *name)
> >> if (!pool->name)
> >> goto err;
> >>
> >> +#ifdef CONFIG_COMPACTION
> >> init_waitqueue_head(&pool->migration_wait);
> >> +#endif
> > The fix is correct. I believe Andrew already has the same patch
> > in his tree.
> >
> > -ss
>
> No reaction of the stable team on this ? Meanwhile, the fix is in the
> mainline tree (commit 441e254cd40dc03beec3c650ce6ce6074bc6517f).
Give us a chance to catch up! :)
> Hopefully it can be included in the next stable releases. However, if I
> read the config text, memory compaction should always be enabled, even
> if it is disabled by default.
It's now queued up everywhere, thanks.
greg k-h
prev parent reply other threads:[~2019-09-02 18:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 12:13 Kernel 5.2.11 dpes not compile François Valenduc
2019-08-29 12:28 ` Jiri Slaby
2019-08-29 12:31 ` François Valenduc
2019-08-29 12:32 ` Sergey Senozhatsky
2019-09-02 18:01 ` François Valenduc
2019-09-02 18:07 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902180738.GA17333@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=francoisvalenduc@gmail.com \
--cc=henryburns@google.com \
--cc=jslaby@suse.cz \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).