From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0EECC3A5A9 for ; Wed, 4 Sep 2019 18:27:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 99D5A20882 for ; Wed, 4 Sep 2019 18:27:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567621659; bh=/zz8r7EZO+1IMMn/392TYhPu1fvB5TNuOucyXPt4Zrc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=l2p2/ixsnY2umYiLqUZSUCgqdA4zTjTBAk/gEyTJv5nJggiTI9+L0HurO+yRutQAC D92E4vcKRit4SgoAkBupWR5Riy7V+fslRWNrHA0kO+E5LIvllQQwn5qDHYk2agKVhq tEVrYwqGQq0QPdvXPd/AcyUhX1tmvv0Jk5PQALuE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733021AbfIDRz5 (ORCPT ); Wed, 4 Sep 2019 13:55:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:32994 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733000AbfIDRz4 (ORCPT ); Wed, 4 Sep 2019 13:55:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CABD522CED; Wed, 4 Sep 2019 17:55:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567619756; bh=/zz8r7EZO+1IMMn/392TYhPu1fvB5TNuOucyXPt4Zrc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FsphpiBbzwGW5HsFwkgQOK4u/jWDOGESBakwC18lTeTYv78SXOPzQxc0reEl7WeAH NA9BKtsaKb7dslCKYX0d9Z0oyiKYAHrtPgfNV7jEYp+NRw788J8zfaZLFvBeJuiNxR rdNqmG1KhhGiycuIgsZOTPL1EPeIBVPpZ/LGEufk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wang Xiayang , Marc Kleine-Budde , Sasha Levin Subject: [PATCH 4.4 15/77] can: peak_usb: force the string buffer NULL-terminated Date: Wed, 4 Sep 2019 19:53:02 +0200 Message-Id: <20190904175305.089206368@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190904175303.317468926@linuxfoundation.org> References: <20190904175303.317468926@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit e787f19373b8a5fa24087800ed78314fd17b984a ] strncpy() does not ensure NULL-termination when the input string size equals to the destination buffer size IFNAMSIZ. The output string is passed to dev_info() which relies on the NULL-termination. Use strlcpy() instead. This issue is identified by a Coccinelle script. Signed-off-by: Wang Xiayang Signed-off-by: Marc Kleine-Budde Signed-off-by: Sasha Levin --- drivers/net/can/usb/peak_usb/pcan_usb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c b/drivers/net/can/usb/peak_usb/pcan_usb_core.c index e13bc27b42911..b1d68f49b3989 100644 --- a/drivers/net/can/usb/peak_usb/pcan_usb_core.c +++ b/drivers/net/can/usb/peak_usb/pcan_usb_core.c @@ -881,7 +881,7 @@ static void peak_usb_disconnect(struct usb_interface *intf) dev_prev_siblings = dev->prev_siblings; dev->state &= ~PCAN_USB_STATE_CONNECTED; - strncpy(name, netdev->name, IFNAMSIZ); + strlcpy(name, netdev->name, IFNAMSIZ); unregister_netdev(netdev); -- 2.20.1