From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C3D4C3A5A9 for ; Wed, 4 Sep 2019 21:20:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26E4C21726 for ; Wed, 4 Sep 2019 21:20:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567632045; bh=Ojqy8ivmyKF5BkwEZLUHZkZNdboqGhLpouawdNXUclQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=uXcZl59TJau91CazYUvS77+0dlMDTXKAFxN2e7hmrE1oCvtGVUJXOJ8am0+ESwNHp ygfexGNP28pj3oV17afkQ42sysev6KnKHjHQrj/r23U7gsb0bH18ZYxVtHjNY7a/fo LKXhdjYYp57lbSpb2sc3147ktCgLoiu3o/2S67gA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727722AbfIDVUo (ORCPT ); Wed, 4 Sep 2019 17:20:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:45018 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726358AbfIDVUo (ORCPT ); Wed, 4 Sep 2019 17:20:44 -0400 Received: from localhost (unknown [209.117.102.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C354F20828; Wed, 4 Sep 2019 21:20:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567632043; bh=Ojqy8ivmyKF5BkwEZLUHZkZNdboqGhLpouawdNXUclQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=To9BkXo/HIhtWlCLEliRLzA2HuJEM6u4Mxb8PHP8wPNMzVKs9a+iU650d2oxPR7aV J2/LL4Tx9YRHFlGHovgPjTlm17Rd0axoECwDoSveJpTfOHePAfJJPOjy+X/rlV1S1p /YrWcJgOY5A00o4poMoD5XjBXIZHZJMLNgSpEVm4= Date: Wed, 4 Sep 2019 17:20:40 -0400 From: Sasha Levin To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, syzbot+c6167ec3de7def23d1e8@syzkaller.appspotmail.com, Arvid Brodin , Cong Wang , "David S. Miller" Subject: Re: [PATCH 5.2 143/143] hsr: implement dellink to clean up resources Message-ID: <20190904212040.GA1616@sasha-vm> References: <20190904175314.206239922@linuxfoundation.org> <20190904175320.090038891@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190904175320.090038891@linuxfoundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Sep 04, 2019 at 07:54:46PM +0200, Greg Kroah-Hartman wrote: >From: Cong Wang > >commit b9a1e627405d68d475a3c1f35e685ccfb5bbe668 upstream. > >hsr_link_ops implements ->newlink() but not ->dellink(), >which leads that resources not released after removing the device, >particularly the entries in self_node_db and node_db. > >So add ->dellink() implementation to replace the priv_destructor. >This also makes the code slightly easier to understand. > >Reported-by: syzbot+c6167ec3de7def23d1e8@syzkaller.appspotmail.com >Cc: Arvid Brodin >Signed-off-by: Cong Wang >Signed-off-by: David S. Miller >Signed-off-by: Greg Kroah-Hartman If the airport gods cooperate, I'm going to queue: edf070a0fb45a ("hsr: fix a NULL pointer deref in hsr_dev_xmit()") 311633b604063 ("hsr: switch ->dellink() to ->ndo_uninit()") as fixes for this commit. -- Thanks, Sasha