From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09EC3C43331 for ; Thu, 5 Sep 2019 18:47:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E432620828 for ; Thu, 5 Sep 2019 18:47:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567709261; bh=eswc6e7PS11qFRA+pb6RWFwrYLnlAocTlT0WwvnKDM8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=RO+g6TY0zwhvcok37E5zX/7biCEU2w+YQFHn4QUtKR/HczQS7qwnE4vR8UhKKkS4R LZm8JzyK+4X1yXzAfse7ebsCMRIHwTP1WBk9EuqmkfV6VlnTi9cP3P2CRWYBHrs68+ IETfty4UOa5UMo5j/MFfKJMHJ61vkmYXf35BZJW8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388258AbfIESrj (ORCPT ); Thu, 5 Sep 2019 14:47:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:51300 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388235AbfIESrj (ORCPT ); Thu, 5 Sep 2019 14:47:39 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 20B3C20825; Thu, 5 Sep 2019 18:47:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567709259; bh=eswc6e7PS11qFRA+pb6RWFwrYLnlAocTlT0WwvnKDM8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fxm3fKmai5Bwytz32dHXB5bIEOG2oI7Va/HGzhqfV6l83B0/v5L6hnIiKbWFNTcLh sGZK5p6+DxT0g9NnZE9IvZVzbzop1yy4fVgjkMqSH0EIQiXQW4V57XRCEADqatHJ7r tWvQbQgyKQTDewG7961CuN5ov1J6lfntV/BUoVyo= Date: Thu, 5 Sep 2019 20:47:35 +0200 From: Greg Kroah-Hartman To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, syzbot+c6167ec3de7def23d1e8@syzkaller.appspotmail.com, Arvid Brodin , Cong Wang , "David S. Miller" Subject: Re: [PATCH 5.2 143/143] hsr: implement dellink to clean up resources Message-ID: <20190905184735.GA24300@kroah.com> References: <20190904175314.206239922@linuxfoundation.org> <20190904175320.090038891@linuxfoundation.org> <20190904212040.GA1616@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190904212040.GA1616@sasha-vm> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Sep 04, 2019 at 05:20:40PM -0400, Sasha Levin wrote: > On Wed, Sep 04, 2019 at 07:54:46PM +0200, Greg Kroah-Hartman wrote: > > From: Cong Wang > > > > commit b9a1e627405d68d475a3c1f35e685ccfb5bbe668 upstream. > > > > hsr_link_ops implements ->newlink() but not ->dellink(), > > which leads that resources not released after removing the device, > > particularly the entries in self_node_db and node_db. > > > > So add ->dellink() implementation to replace the priv_destructor. > > This also makes the code slightly easier to understand. > > > > Reported-by: syzbot+c6167ec3de7def23d1e8@syzkaller.appspotmail.com > > Cc: Arvid Brodin > > Signed-off-by: Cong Wang > > Signed-off-by: David S. Miller > > Signed-off-by: Greg Kroah-Hartman > > If the airport gods cooperate, I'm going to queue: > > edf070a0fb45a ("hsr: fix a NULL pointer deref in hsr_dev_xmit()") > 311633b604063 ("hsr: switch ->dellink() to ->ndo_uninit()") > > as fixes for this commit. Ugh, sorry about that, I need to fix up my scripts :( greg k-h