From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Sasha Levin <sashal@kernel.org>,
stable@vger.kernel.org, clang-built-linux@googlegroups.com,
Ilie Halip <ilie.halip@gmail.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Zhenzhong Duan <zhenzhong.duan@oracle.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 4.4] x86, boot: Remove multiple copy of static function sanitize_boot_params()
Date: Thu, 12 Sep 2019 11:31:14 +0100 [thread overview]
Message-ID: <20190912103114.GA56013@kroah.com> (raw)
In-Reply-To: <20190912072146.68410-1-natechancellor@gmail.com>
On Thu, Sep 12, 2019 at 12:21:48AM -0700, Nathan Chancellor wrote:
> From: Zhenzhong Duan <zhenzhong.duan@oracle.com>
>
> commit 8c5477e8046ca139bac250386c08453da37ec1ae upstream.
>
> Kernel build warns:
> 'sanitize_boot_params' defined but not used [-Wunused-function]
>
> at below files:
> arch/x86/boot/compressed/cmdline.c
> arch/x86/boot/compressed/error.c
> arch/x86/boot/compressed/early_serial_console.c
> arch/x86/boot/compressed/acpi.c
>
> That's becausethey each include misc.h which includes a definition of
> sanitize_boot_params() via bootparam_utils.h.
>
> Remove the inclusion from misc.h and have the c file including
> bootparam_utils.h directly.
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Link: https://lkml.kernel.org/r/1563283092-1189-1-git-send-email-zhenzhong.duan@oracle.com
> [nc: Fixed conflict around lack of 67b6662559f7f]
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
>
> Hi Greg and Sasha,
>
> Please consider applying this to 4.4 as it resolves a compilation error
> with clang on 4.4 and it has already been applied to 4.9 and newer:
>
> https://travis-ci.com/ClangBuiltLinux/continuous-integration/jobs/232287034
>
> https://github.com/ClangBuiltLinux/linux/issues/654
>
> Thanks to Ilie Halip for debugging this; TL;DR: clang pretends that it
> is GCC 4.2.1 for glibc compatibility and this trips up a definition of
> memcpy for GCC < 4.3. This is not an issue on mainline because GCC 4.6
> is the earliest supported GCC version so that code was removed and this
> patch resolves it because string.h redefines memcpy to a proper version.
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2019-09-12 10:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 7:21 [PATCH 4.4] x86, boot: Remove multiple copy of static function sanitize_boot_params() Nathan Chancellor
2019-09-12 10:31 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190912103114.GA56013@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=clang-built-linux@googlegroups.com \
--cc=ilie.halip@gmail.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).