From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9191C4CEC5 for ; Fri, 13 Sep 2019 13:23:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A404520CC7 for ; Fri, 13 Sep 2019 13:23:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568381038; bh=Rf6qUyXdmzvg5p/hB2kjRxuWuQju+uozMGVXAP2Bo7s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JiuEAqWtn3alD6xcSm844BpXLjcPXpXT8abKnoQ5dWKM9EkPau7vp4vbtK/YbtAiO kWxGDHr9HARPYGJR1AA9G/ahwq3AIxJ/dEvJcCe5jLQT0qEV3LF/KBdI8ISPYKFmSj p8nU/rmxDBKE0Ad3PZfkuQyu78dyUD6QJCLOq9Ks= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390290AbfIMNX5 (ORCPT ); Fri, 13 Sep 2019 09:23:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:49600 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390039AbfIMNUd (ORCPT ); Fri, 13 Sep 2019 09:20:33 -0400 Received: from localhost (unknown [104.132.45.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E1BD7206A5; Fri, 13 Sep 2019 13:20:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568380833; bh=Rf6qUyXdmzvg5p/hB2kjRxuWuQju+uozMGVXAP2Bo7s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AorLgTSiLXomoKrgIzVIrvfFBgRTOqWji5xwi6f71to0y5T2HRlwSPeuAeXcr87x1 vyg5Rd06ye+0LW+jxkpm2s2l9DO80HAUq6i2AlhQz9eHTtXsff/VZ2Jx3YsFCXnBNN u39RYKJUNlYqfYL8aUc7cqNFBs3q2Lco1F5ncHG4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Theodore Tso , Sasha Levin Subject: [PATCH 4.19 185/190] ext4: unsigned int compared against zero Date: Fri, 13 Sep 2019 14:07:20 +0100 Message-Id: <20190913130614.664496925@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190913130559.669563815@linuxfoundation.org> References: <20190913130559.669563815@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit fbbbbd2f28aec991f3fbc248df211550fbdfd58c ] There are two cases where u32 variables n and err are being checked for less than zero error values, the checks is always false because the variables are not signed. Fix this by making the variables ints. Addresses-Coverity: ("Unsigned compared against 0") Fixes: 345c0dbf3a30 ("ext4: protect journal inode's blocks using block_validity") Signed-off-by: Colin Ian King Signed-off-by: Theodore Ts'o Signed-off-by: Sasha Levin --- fs/ext4/block_validity.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c index cd7129b622f85..e8e27cdc2f677 100644 --- a/fs/ext4/block_validity.c +++ b/fs/ext4/block_validity.c @@ -142,7 +142,8 @@ static int ext4_protect_reserved_inode(struct super_block *sb, u32 ino) struct inode *inode; struct ext4_sb_info *sbi = EXT4_SB(sb); struct ext4_map_blocks map; - u32 i = 0, err = 0, num, n; + u32 i = 0, num; + int err = 0, n; if ((ino < EXT4_ROOT_INO) || (ino > le32_to_cpu(sbi->s_es->s_inodes_count))) -- 2.20.1