From: Greg Kurz <groug@kaod.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras <paulus@ozlabs.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] powerpc/xive: Fix bogus error code returned by OPAL
Date: Fri, 13 Sep 2019 13:12:21 +0200 [thread overview]
Message-ID: <20190913131221.3ea88b5a@bahia.lan> (raw)
In-Reply-To: <20190912073049.CF36B20830@mail.kernel.org>
On Thu, 12 Sep 2019 07:30:49 +0000
Sasha Levin <sashal@kernel.org> wrote:
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: 4.12+
>
> The bot has tested the following trees: v5.2.14, v4.19.72, v4.14.143.
>
> v5.2.14: Build OK!
> v4.19.72: Failed to apply! Possible dependencies:
> 75d9fc7fd94e ("powerpc/powernv: move OPAL call wrapper tracing and interrupt handling to C")
>
This is the only dependency indeed.
> v4.14.143: Failed to apply! Possible dependencies:
> 104daea149c4 ("kconfig: reference environment variables directly and remove 'option env='")
> 21c54b774744 ("kconfig: show compiler version text in the top comment")
> 315bab4e972d ("kbuild: fix endless syncconfig in case arch Makefile sets CROSS_COMPILE")
> 3298b690b21c ("kbuild: Add a cache for generated variables")
> 4e56207130ed ("kbuild: Cache a few more calls to the compiler")
> 75d9fc7fd94e ("powerpc/powernv: move OPAL call wrapper tracing and interrupt handling to C")
> 8f2133cc0e1f ("powerpc/pseries: hcall_exit tracepoint retval should be signed")
> 9a234a2e3843 ("kbuild: create directory for make cache only when necessary")
> d677a4d60193 ("Makefile: support flag -fsanitizer-coverage=trace-cmp")
> e08d6de4e532 ("kbuild: remove kbuild cache")
> e17c400ae194 ("kbuild: shrink .cache.mk when it exceeds 1000 lines")
> e501ce957a78 ("x86: Force asm-goto")
> e9666d10a567 ("jump_label: move 'asm goto' support test to Kconfig")
>
That's quite a lot of patches to workaround a hard to hit skiboot bug.
As an alternative, the patch can be backported so that it applies the
following change:
-OPAL_CALL(opal_xive_allocate_irq, OPAL_XIVE_ALLOCATE_IRQ);
+OPAL_CALL(opal_xive_allocate_irq_raw, OPAL_XIVE_ALLOCATE_IRQ);
to "arch/powerpc/platforms/powernv/opal-wrappers.S"
instead of "arch/powerpc/platforms/powernv/opal-call.c" .
BTW, this could also be done for 4.19.y .
>
> NOTE: The patch will not be queued to stable trees until it is upstream.
>
> How should we proceed with this patch?
>
Michael ?
> --
> Thanks,
> Sasha
next parent reply other threads:[~2019-09-13 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <156821713818.1985334.14123187368108582810.stgit@bahia.lan>
[not found] ` <20190912073049.CF36B20830@mail.kernel.org>
2019-09-13 11:12 ` Greg Kurz [this message]
2019-09-17 4:09 ` [PATCH v2] powerpc/xive: Fix bogus error code returned by OPAL Michael Ellerman
2019-09-17 5:06 ` Greg KH
2019-09-17 6:13 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913131221.3ea88b5a@bahia.lan \
--to=groug@kaod.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@ozlabs.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox