From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: stable <stable@vger.kernel.org>,
"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: Please revert upstream commit e4849aff1e16 ("MIPS: SiByte: Enable swiotlb ...") in v4.4.y and v4.14.y
Date: Mon, 16 Sep 2019 17:03:32 +0200 [thread overview]
Message-ID: <20190916150332.GA1645163@kroah.com> (raw)
In-Reply-To: <c7bc60c5-1219-089d-8062-17c63a3210d1@roeck-us.net>
On Mon, Sep 16, 2019 at 06:15:59AM -0700, Guenter Roeck wrote:
> On 9/15/19 11:07 PM, Greg Kroah-Hartman wrote:
> > On Sun, Sep 15, 2019 at 04:01:08PM -0700, Guenter Roeck wrote:
> > > Upstream commit e4849aff1e16 ("MIPS: SiByte: Enable swiotlb for SWARM,
> > > LittleSur and BigSur") results in build failures in v4.4.y and v4.14.y.
> > >
> > > make bigsur_defconfig:
> > >
> > > warning: (SIBYTE_SWARM && SIBYTE_SENTOSA && SIBYTE_BIGSUR && SWIOTLB_XEN && AMD_IOMMU) selects SWIOTLB which has unmet direct dependencies (CAVIUM_OCTEON_SOC || MACH_LOONGSON64 && CPU_LOONGSON3 || NLM_XLP_BOARD || NLM_XLR_BOARD)
> > > warning: (SIBYTE_SWARM && SIBYTE_SENTOSA && SIBYTE_BIGSUR && SWIOTLB_XEN && AMD_IOMMU) selects SWIOTLB which has unmet direct dependencies (CAVIUM_OCTEON_SOC || MACH_LOONGSON64 && CPU_LOONGSON3 || NLM_XLP_BOARD || NLM_XLR_BOARD)
> > >
> > > and the actual build:
> > >
> > > lib/swiotlb.o: In function `swiotlb_tbl_map_single':
> > > (.text+0x1c0): undefined reference to `iommu_is_span_boundary'
> > > Makefile:1021: recipe for target 'vmlinux' failed
> > >
> > > Please revert.
> >
> > Shouldn't I also revert it in 4.9.y?
> >
>
> Yes, of course. Sorry. Somehow 4.9 keeps slipping my mind :-(.
Now queued up for all of those branches, thanks.
greg k-h
next prev parent reply other threads:[~2019-09-16 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-15 23:01 Please revert upstream commit e4849aff1e16 ("MIPS: SiByte: Enable swiotlb ...") in v4.4.y and v4.14.y Guenter Roeck
2019-09-16 6:07 ` Greg Kroah-Hartman
2019-09-16 13:15 ` Guenter Roeck
2019-09-16 15:03 ` Greg Kroah-Hartman [this message]
2019-09-16 22:58 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916150332.GA1645163@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux@roeck-us.net \
--cc=macro@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).