From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C23DC4CEC9 for ; Wed, 18 Sep 2019 06:33:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 355DF218AE for ; Wed, 18 Sep 2019 06:33:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568788399; bh=8Oga840qT7mNdbKHWlniyreRrb6tdK+loARl/EV5NNI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OhHB1FCAJ5uQpCjnpJ612EsnkVd0W5yKC+/5Zl+T4H/kWAdDWInk2zoXc7cuRsJxq aLPOJbi85VegnFvDTgTbRckwWU9kRSM9Beax0uoMtKkWahQuL+ExG+2TEYnxipyE6k Ooe10bQ+2Z0HJWejzeqYWH5q7STYtpo+wgkWYJuE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728841AbfIRGU5 (ORCPT ); Wed, 18 Sep 2019 02:20:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:40040 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728847AbfIRGUy (ORCPT ); Wed, 18 Sep 2019 02:20:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C2C19222BD; Wed, 18 Sep 2019 06:20:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568787654; bh=8Oga840qT7mNdbKHWlniyreRrb6tdK+loARl/EV5NNI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2VkkYh535KMCMpb2uQ5ZXIMmnX9rDNiV/KCbXkKtuq0Ck8KstmsbZ2uDDZAi2lWRT lFLQRXr8syQm96i13Vwy4mf8HM2yn2S8Bx83LkhVTimGmI8/zA5GUppBTfF+FZxFHY iCr9n6w0dQT9qV/WEuaOv7iHWHA9Ii+bSUdEZVcI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Douglas Anderson , Heiko Stuebner Subject: [PATCH 4.14 29/45] clk: rockchip: Dont yell about bad mmc phases when getting Date: Wed, 18 Sep 2019 08:19:07 +0200 Message-Id: <20190918061226.298005862@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190918061222.854132812@linuxfoundation.org> References: <20190918061222.854132812@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Douglas Anderson commit 6943b839721ad4a31ad2bacf6e71b21f2dfe3134 upstream. At boot time, my rk3288-veyron devices yell with 8 lines that look like this: [ 0.000000] rockchip_mmc_get_phase: invalid clk rate This is because the clock framework at clk_register() time tries to get the phase but we don't have a parent yet. While the errors appear to be harmless they are still ugly and, in general, we don't want yells like this in the log unless they are important. There's no real reason to be yelling here. We can still return -EINVAL to indicate that the phase makes no sense without a parent. If someone really tries to do tuning and the clock is reported as 0 then we'll see the yells in rockchip_mmc_set_phase(). Fixes: 4bf59902b500 ("clk: rockchip: Prevent calculating mmc phase if clock rate is zero") Signed-off-by: Douglas Anderson Signed-off-by: Heiko Stuebner Signed-off-by: Greg Kroah-Hartman --- drivers/clk/rockchip/clk-mmc-phase.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/drivers/clk/rockchip/clk-mmc-phase.c +++ b/drivers/clk/rockchip/clk-mmc-phase.c @@ -59,10 +59,8 @@ static int rockchip_mmc_get_phase(struct u32 delay_num = 0; /* See the comment for rockchip_mmc_set_phase below */ - if (!rate) { - pr_err("%s: invalid clk rate\n", __func__); + if (!rate) return -EINVAL; - } raw_value = readl(mmc_clock->reg) >> (mmc_clock->shift);