From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95777C4CEC9 for ; Wed, 18 Sep 2019 06:28:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E15A21906 for ; Wed, 18 Sep 2019 06:28:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568788122; bh=FUAoHiJRL3qgdI+/miMRFMIFYjyObvtwgXnvXln8pNU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vJ76PpNmHgylzgAt0oqyEfw94wUxPBrO1pDBmbDOZUKEEE4lM3KFds3NkkGe5Pdwn NOpYJdwgQflsFOqkGpNIZjAmlx/V5Ze6cepcSfcdxFBF68EEVqw7V/ksekoIBUX2FP LNeO8HaeO4LjrlTVLfcuVNCxKwcGxbcJHHy4hfMs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728045AbfIRG1M (ORCPT ); Wed, 18 Sep 2019 02:27:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:48944 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730476AbfIRG1L (ORCPT ); Wed, 18 Sep 2019 02:27:11 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DB1B0218AF; Wed, 18 Sep 2019 06:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568788030; bh=FUAoHiJRL3qgdI+/miMRFMIFYjyObvtwgXnvXln8pNU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GQ/KBds4psBfHEahDvjS/4UXw2rpo9yjhw0h6UPrdvUmjZ1p8cqu//3NcUyMJ1ti2 bC9KXgOV/OEX4Y7bMDQALcLMDFEqueje9X9m8gkO+b2PeA3mA51Gs8ooq85LVg5wTQ IzdN2V+Nj1T5RNzMuiEJPiM+CFTk+zmJ33lukdNg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Gustavo A. R. Silva" , Andrew Morton , Henry Burns , Vitaly Wool , Shakeel Butt , Linus Torvalds Subject: [PATCH 5.2 73/85] mm/z3fold.c: fix lock/unlock imbalance in z3fold_page_isolate Date: Wed, 18 Sep 2019 08:19:31 +0200 Message-Id: <20190918061237.710903376@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190918061234.107708857@linuxfoundation.org> References: <20190918061234.107708857@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Gustavo A. R. Silva commit 14108b9131a47ff18a3c640f583eb2d625c75c0d upstream. Fix lock/unlock imbalance by unlocking *zhdr* before return. Addresses Coverity ID 1452811 ("Missing unlock") Link: http://lkml.kernel.org/r/20190826030634.GA4379@embeddedor Fixes: d776aaa9895e ("mm/z3fold.c: fix race between migration and destruction") Signed-off-by: Gustavo A. R. Silva Reviewed-by: Andrew Morton Cc: Henry Burns Cc: Vitaly Wool Cc: Shakeel Butt Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- mm/z3fold.c | 1 + 1 file changed, 1 insertion(+) --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -1408,6 +1408,7 @@ static bool z3fold_page_isolate(struct p * should freak out. */ WARN(1, "Z3fold is experiencing kref problems\n"); + z3fold_page_unlock(zhdr); return false; } z3fold_page_unlock(zhdr);