From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9528FC4740C for ; Sun, 22 Sep 2019 19:10:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E4BB21907 for ; Sun, 22 Sep 2019 19:10:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569179423; bh=wNr6pegQhACiQ4qzoUw117XMXI00XuVxmvoZN5YDoVM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=db74vRyrHI0kBG3ysjxhTSJb8+aImf2Ae/veFUdcawI+L9EF2TG7YZzfvETHumSON NgShXdaxlk6foNoPTUb0YwgqW9n9rCqVNMSGcuBusKAdNKV5ZZvcxMXn31rmlmf5AF CcII6jqN9pF0ii+HUnq6DLc6+KMaB5rhQZa5BTS8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438807AbfIVS6p (ORCPT ); Sun, 22 Sep 2019 14:58:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:33528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394926AbfIVS6o (ORCPT ); Sun, 22 Sep 2019 14:58:44 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1C14E2190F; Sun, 22 Sep 2019 18:58:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569178723; bh=wNr6pegQhACiQ4qzoUw117XMXI00XuVxmvoZN5YDoVM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rc/7qLMHbf6WB9Z+tfw/oiOlUpMcBqbuRm7xCGeK8tMS9KjWJrrjL0dYC5496XQhW t0uiA0bDhSNeVqxuAJ/SFQL+eRBfQ8K8beuTSgk9YOAKYlklME/KKgzLWBU2L4oIpc lPWjX/DrknkBKfMOIFj6D/ag7qPO3fJnHv4UMLew= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wenwen Wang , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 55/89] media: saa7146: add cleanup in hexium_attach() Date: Sun, 22 Sep 2019 14:56:43 -0400 Message-Id: <20190922185717.3412-55-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922185717.3412-1-sashal@kernel.org> References: <20190922185717.3412-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Wenwen Wang [ Upstream commit 42e64117d3b4a759013f77bbcf25ab6700e55de7 ] If saa7146_register_device() fails, no cleanup is executed, leading to memory/resource leaks. To fix this issue, perform necessary cleanup work before returning the error. Signed-off-by: Wenwen Wang Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/pci/saa7146/hexium_gemini.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/pci/saa7146/hexium_gemini.c b/drivers/media/pci/saa7146/hexium_gemini.c index 934332f1fd8e6..a527d86b93a77 100644 --- a/drivers/media/pci/saa7146/hexium_gemini.c +++ b/drivers/media/pci/saa7146/hexium_gemini.c @@ -304,6 +304,9 @@ static int hexium_attach(struct saa7146_dev *dev, struct saa7146_pci_extension_d ret = saa7146_register_device(&hexium->video_dev, dev, "hexium gemini", VFL_TYPE_GRABBER); if (ret < 0) { pr_err("cannot register capture v4l2 device. skipping.\n"); + saa7146_vv_release(dev); + i2c_del_adapter(&hexium->i2c_adapter); + kfree(hexium); return ret; } -- 2.20.1