From: Greg KH <gregkh@linuxfoundation.org>
To: Chris Brandt <chris.brandt@renesas.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
stable@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Chien Nguyen <chien.nguyen.eb@rvc.renesas.com>
Subject: Re: [PATCH] i2c: riic: Clear NACK in tend isr
Date: Thu, 26 Sep 2019 06:54:59 +0200 [thread overview]
Message-ID: <20190926045459.GA1560081@kroah.com> (raw)
In-Reply-To: <20190925194327.28109-1-chris.brandt@renesas.com>
On Wed, Sep 25, 2019 at 02:43:27PM -0500, Chris Brandt wrote:
> The NACKF flag should be cleared in INTRIICNAKI interrupt processing as
> description in HW manual.
>
> This issue shows up quickly when PREEMPT_RT is applied and a device is
> probed that is not plugged in (like a touchscreen controller). The result
> is endless interrupts that halt system boot.
>
> Fixes: 310c18a41450 ("i2c: riic: add driver")
> Reported-by: Chien Nguyen <chien.nguyen.eb@rvc.renesas.com>
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
> ---
> drivers/i2c/busses/i2c-riic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-riic.c b/drivers/i2c/busses/i2c-riic.c
> index f31413fd9521..800414886f6b 100644
> --- a/drivers/i2c/busses/i2c-riic.c
> +++ b/drivers/i2c/busses/i2c-riic.c
> @@ -202,6 +202,7 @@ static irqreturn_t riic_tend_isr(int irq, void *data)
> if (readb(riic->base + RIIC_ICSR2) & ICSR2_NACKF) {
> /* We got a NACKIE */
> readb(riic->base + RIIC_ICDRR); /* dummy read */
> + riic_clear_set_bit(riic, ICSR2_NACKF, 0, RIIC_ICSR2);
> riic->err = -ENXIO;
> } else if (riic->bytes_left) {
> return IRQ_NONE;
> --
> 2.23.0
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
prev parent reply other threads:[~2019-09-26 4:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 19:43 [PATCH] i2c: riic: Clear NACK in tend isr Chris Brandt
2019-09-26 4:54 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926045459.GA1560081@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chien.nguyen.eb@rvc.renesas.com \
--cc=chris.brandt@renesas.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).