From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: exynos: Revert "Remove unneeded address space mapping for soc node"
Date: Tue, 1 Oct 2019 21:16:23 +0200 [thread overview]
Message-ID: <20191001191623.GB30860@kozik-lap> (raw)
In-Reply-To: <20190912073602.22829-1-m.szyprowski@samsung.com>
On Thu, Sep 12, 2019 at 09:36:02AM +0200, Marek Szyprowski wrote:
> Commit ef72171b3621 ("arm64: dts: exynos: Remove unneeded address space
> mapping for soc node") changed the address and size cells in root node from
> 2 to 1, but /memory nodes for the affected boards were not updated. This
> went unnoticed on Exynos5433-based TM2(e) boards, because they use u-boot,
> which updates /memory node to the correct values. On the other hand, the
> mentioned commit broke boot on Exynos7-based Espresso board, which
> bootloader doesn't touch /memory node at all.
>
> This patch reverts commit ef72171b3621, so Exynos5433 and Exynos7 SoCs
> again matches other ARM64 platforms with 64bit mappings in root node.
>
> Reported-by: Alim Akhtar <alim.akhtar@samsung.com>
> Fixes: ef72171b3621 ("arm64: dts: exynos: Remove unneeded address space mapping for soc node")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: <stable@vger.kernel.org>
> Tested-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
> A few more comments:
>
> 1. I've added 'tested-by' tag from Alim, as his original report pointed
> that reverting the offending commit fixes the boot issue.
>
> 2. This patch applies down to v4.18.
>
> 3. For v5.3 release, two patches:
> - "arm64: dts: exynos: Move GPU under /soc node for Exynos5433"
> - "arm64: dts: exynos: Move GPU under /soc node for Exynos7"
> has to be applied first to ensure that GPU node will have correct 'reg'
> property (nodes under /soc still use 32bit mappings). I'm not sure if
Thanks, applied.
I tried the cc-stable-with-prerequisites syntax. It looks like this:
https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/commit/?h=next/dt64&id=bed903167ae5b5532eda5d7db26de451bd232da5
I hope it will work...
Best regards,
Krzysztof
prev parent reply other threads:[~2019-10-01 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190912073608eucas1p1c2da86b1f85244a507b0f2ce96390ad3@eucas1p1.samsung.com>
2019-09-12 7:36 ` [PATCH] arm64: dts: exynos: Revert "Remove unneeded address space mapping for soc node" Marek Szyprowski
2019-09-12 11:56 ` Alim Akhtar
2019-10-01 19:16 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001191623.GB30860@kozik-lap \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox