* [PATCH] USB: microtek: fix info-leak at probe
[not found] <0000000000000e235d0593f474ba@google.com>
@ 2019-10-03 7:09 ` Johan Hovold
2019-10-03 8:10 ` Oliver Neukum
0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2019-10-03 7:09 UTC (permalink / raw)
To: Oliver Neukum
Cc: Greg Kroah-Hartman, linux-usb, Johan Hovold, stable,
syzbot+5630ca7c3b2be5c9da5e
Add missing bulk-in endpoint sanity check to prevent uninitialised stack
data from being reported to the system log and used as endpoint
addresses.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org>
Reported-by: syzbot+5630ca7c3b2be5c9da5e@syzkaller.appspotmail.com
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/image/microtek.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/image/microtek.c b/drivers/usb/image/microtek.c
index 0a57c2cc8e5a..7a6b122c833f 100644
--- a/drivers/usb/image/microtek.c
+++ b/drivers/usb/image/microtek.c
@@ -716,6 +716,10 @@ static int mts_usb_probe(struct usb_interface *intf,
}
+ if (ep_in_current != &ep_in_set[2]) {
+ MTS_WARNING("couldn't find two input bulk endpoints. Bailing out.\n");
+ return -ENODEV;
+ }
if ( ep_out == -1 ) {
MTS_WARNING( "couldn't find an output bulk endpoint. Bailing out.\n" );
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] USB: microtek: fix info-leak at probe
2019-10-03 7:09 ` [PATCH] USB: microtek: fix info-leak at probe Johan Hovold
@ 2019-10-03 8:10 ` Oliver Neukum
0 siblings, 0 replies; 2+ messages in thread
From: Oliver Neukum @ 2019-10-03 8:10 UTC (permalink / raw)
To: Johan Hovold
Cc: Greg Kroah-Hartman, syzbot+5630ca7c3b2be5c9da5e, linux-usb,
stable
Am Donnerstag, den 03.10.2019, 09:09 +0200 schrieb Johan Hovold:
> Add missing bulk-in endpoint sanity check to prevent uninitialised stack
> data from being reported to the system log and used as endpoint
> addresses.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: stable <stable@vger.kernel.org>
> Reported-by: syzbot+5630ca7c3b2be5c9da5e@syzkaller.appspotmail.com
> Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Oliver Neukum <oneukum@suse.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-03 8:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <0000000000000e235d0593f474ba@google.com>
2019-10-03 7:09 ` [PATCH] USB: microtek: fix info-leak at probe Johan Hovold
2019-10-03 8:10 ` Oliver Neukum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).