From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: laoar.shao@gmail.com, akpm@linux-foundation.org,
mgorman@techsingularity.net, mhocko@suse.com,
rientjes@google.com, shaoyafang@didiglobal.com,
stable@vger.kernel.org, torvalds@linux-foundation.org,
vbabka@suse.cz
Subject: Re: FAILED: patch "[PATCH] mm/compaction.c: clear total_{migrate,free}_scanned before" failed to apply to 4.19-stable tree
Date: Thu, 3 Oct 2019 09:41:35 -0400 [thread overview]
Message-ID: <20191003134135.GY17454@sasha-vm> (raw)
In-Reply-To: <157010272680112@kroah.com>
On Thu, Oct 03, 2019 at 01:38:46PM +0200, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.19-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From a94b525241c0fff3598809131d7cfcfe1d572d8c Mon Sep 17 00:00:00 2001
>From: Yafang Shao <laoar.shao@gmail.com>
>Date: Mon, 23 Sep 2019 15:36:54 -0700
>Subject: [PATCH] mm/compaction.c: clear total_{migrate,free}_scanned before
> scanning a new zone
>
>total_{migrate,free}_scanned will be added to COMPACTMIGRATE_SCANNED and
>COMPACTFREE_SCANNED in compact_zone(). We should clear them before
>scanning a new zone. In the proc triggered compaction, we forgot clearing
>them.
>
>[laoar.shao@gmail.com: introduce a helper compact_zone_counters_init()]
> Link: http://lkml.kernel.org/r/1563869295-25748-1-git-send-email-laoar.shao@gmail.com
>[akpm@linux-foundation.org: expand compact_zone_counters_init() into its single callsite, per mhocko]
>[vbabka@suse.cz: squash compact_zone() list_head init as well]
> Link: http://lkml.kernel.org/r/1fb6f7da-f776-9e42-22f8-bbb79b030b98@suse.cz
>[akpm@linux-foundation.org: kcompactd_do_work(): avoid unnecessary initialization of cc.zone]
>Link: http://lkml.kernel.org/r/1563789275-9639-1-git-send-email-laoar.shao@gmail.com
>Fixes: 7f354a548d1c ("mm, compaction: add vmstats for kcompactd work")
>Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
>Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
>Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
>Cc: David Rientjes <rientjes@google.com>
>Cc: Yafang Shao <shaoyafang@didiglobal.com>
>Cc: Mel Gorman <mgorman@techsingularity.net>
>Cc: Michal Hocko <mhocko@suse.com>
>Cc: <stable@vger.kernel.org>
>Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This was mostly due to unrelated code cleanups. I've queued up a
backport for 4.19 and 4.14, it's not needed on older kernels.
--
Thanks,
Sasha
prev parent reply other threads:[~2019-10-03 13:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 11:38 FAILED: patch "[PATCH] mm/compaction.c: clear total_{migrate,free}_scanned before" failed to apply to 4.19-stable tree gregkh
2019-10-03 13:41 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191003134135.GY17454@sasha-vm \
--to=sashal@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=laoar.shao@gmail.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=rientjes@google.com \
--cc=shaoyafang@didiglobal.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).