From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_SBL,URIBL_SBL_A,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75356C10F14 for ; Thu, 3 Oct 2019 13:41:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F69320873 for ; Thu, 3 Oct 2019 13:41:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570110098; bh=yRxzVsfeJ3KZt8CQmRSjCw2u/c1hrTkgYN5NecdUw+s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=sQ36yIA/Fp7bRbR9OGZ/tRb2NXtxw6sve8nJthPIKz6Zg+emQOeiOYw68JNF/D/3S V1p0R31ESXBYNvSdB3WvvWpqJ+QSXV7ycJWO2KGXIS74TOiYVneCAMc5/xvT0Z7xCK dtbVFavxaKCmCR5rqBBTHKwJG9CflTx9bPlB+PPM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729440AbfJCNlh (ORCPT ); Thu, 3 Oct 2019 09:41:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:53142 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725932AbfJCNlh (ORCPT ); Thu, 3 Oct 2019 09:41:37 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D12020865; Thu, 3 Oct 2019 13:41:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570110096; bh=yRxzVsfeJ3KZt8CQmRSjCw2u/c1hrTkgYN5NecdUw+s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EZ2L8DDfav9hjMZfQRK3bRnoZNTzjKxFyZMw08c4mFK92JSd+UEhynD296mDBPf86 /9YNJtcMW5SKMOztJB34KmeBG3G1ktwqxbiXvoJ4uSPiuJLbU8cTyFYbPmtHY1S8OB vXcr6/c6rQHu8oOXVAmTGQ2wFXDzGem8yOzlT2pA= Date: Thu, 3 Oct 2019 09:41:35 -0400 From: Sasha Levin To: gregkh@linuxfoundation.org Cc: laoar.shao@gmail.com, akpm@linux-foundation.org, mgorman@techsingularity.net, mhocko@suse.com, rientjes@google.com, shaoyafang@didiglobal.com, stable@vger.kernel.org, torvalds@linux-foundation.org, vbabka@suse.cz Subject: Re: FAILED: patch "[PATCH] mm/compaction.c: clear total_{migrate,free}_scanned before" failed to apply to 4.19-stable tree Message-ID: <20191003134135.GY17454@sasha-vm> References: <157010272680112@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <157010272680112@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Oct 03, 2019 at 01:38:46PM +0200, gregkh@linuxfoundation.org wrote: > >The patch below does not apply to the 4.19-stable tree. >If someone wants it applied there, or to any other stable or longterm >tree, then please email the backport, including the original git commit >id to . > >thanks, > >greg k-h > >------------------ original commit in Linus's tree ------------------ > >>From a94b525241c0fff3598809131d7cfcfe1d572d8c Mon Sep 17 00:00:00 2001 >From: Yafang Shao >Date: Mon, 23 Sep 2019 15:36:54 -0700 >Subject: [PATCH] mm/compaction.c: clear total_{migrate,free}_scanned before > scanning a new zone > >total_{migrate,free}_scanned will be added to COMPACTMIGRATE_SCANNED and >COMPACTFREE_SCANNED in compact_zone(). We should clear them before >scanning a new zone. In the proc triggered compaction, we forgot clearing >them. > >[laoar.shao@gmail.com: introduce a helper compact_zone_counters_init()] > Link: http://lkml.kernel.org/r/1563869295-25748-1-git-send-email-laoar.shao@gmail.com >[akpm@linux-foundation.org: expand compact_zone_counters_init() into its single callsite, per mhocko] >[vbabka@suse.cz: squash compact_zone() list_head init as well] > Link: http://lkml.kernel.org/r/1fb6f7da-f776-9e42-22f8-bbb79b030b98@suse.cz >[akpm@linux-foundation.org: kcompactd_do_work(): avoid unnecessary initialization of cc.zone] >Link: http://lkml.kernel.org/r/1563789275-9639-1-git-send-email-laoar.shao@gmail.com >Fixes: 7f354a548d1c ("mm, compaction: add vmstats for kcompactd work") >Signed-off-by: Yafang Shao >Signed-off-by: Vlastimil Babka >Reviewed-by: Vlastimil Babka >Cc: David Rientjes >Cc: Yafang Shao >Cc: Mel Gorman >Cc: Michal Hocko >Cc: >Signed-off-by: Andrew Morton >Signed-off-by: Linus Torvalds This was mostly due to unrelated code cleanups. I've queued up a backport for 4.19 and 4.14, it's not needed on older kernels. -- Thanks, Sasha