From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44CC3C32792 for ; Thu, 3 Oct 2019 17:40:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0E64E20865 for ; Thu, 3 Oct 2019 17:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570124401; bh=s0VKegK65BOo4RZtUtGMJWSPHCFObkHhF0ExV3MMKUE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=n/WgZdHdhEZnjnou/Te5RKKQVcTHQw+hLo2cgyrW0QvjXXHBJadlUhCjCz8OAVO/H ZJHNfEXxjVyIgH2MbH/GPZT6gjlLRwc4IopFYimBBQzHIcXZhguvEaEeDNpb0OBHIg WbnEn5IFU5jjL0ABAnCwG5t9P4eiEfKeRD3DBqpM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729838AbfJCQAp (ORCPT ); Thu, 3 Oct 2019 12:00:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:44606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730115AbfJCQAo (ORCPT ); Thu, 3 Oct 2019 12:00:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D6AD20700; Thu, 3 Oct 2019 16:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570118443; bh=s0VKegK65BOo4RZtUtGMJWSPHCFObkHhF0ExV3MMKUE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z8BntorKKjuD3T3OQlevLHc2QkQiOOt7HjcHZKESsBzXOaBGiSMpEuG4bmLKHQRNv SnS37s8+nk6ol6arIoGazsR3M5qXNv1rxGVFOx0UlxeN34/477Hc8kv0DqhRKuEP47 u8XzgKxE00x0owdndAhO9aUL0n1yv2G44Z1D0/ng= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, David Lechner , Sebastian Reichel , Sasha Levin Subject: [PATCH 4.9 014/129] power: supply: sysfs: ratelimit property read error message Date: Thu, 3 Oct 2019 17:52:17 +0200 Message-Id: <20191003154325.595664911@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154318.081116689@linuxfoundation.org> References: <20191003154318.081116689@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: David Lechner [ Upstream commit 87a2b65fc855e6be50f791c2ebbb492541896827 ] This adds rate limiting to the message that is printed when reading a power supply property via sysfs returns an error. This will prevent userspace applications from unintentionally dDOSing the system by continuously reading a property that returns an error. Signed-off-by: David Lechner Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/power_supply_sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c index c0fc98e03c912..85cb5b9c1b6f0 100644 --- a/drivers/power/supply/power_supply_sysfs.c +++ b/drivers/power/supply/power_supply_sysfs.c @@ -84,7 +84,8 @@ static ssize_t power_supply_show_property(struct device *dev, dev_dbg(dev, "driver has no data for `%s' property\n", attr->attr.name); else if (ret != -ENODEV && ret != -EAGAIN) - dev_err(dev, "driver failed to report `%s' property: %zd\n", + dev_err_ratelimited(dev, + "driver failed to report `%s' property: %zd\n", attr->attr.name, ret); return ret; } -- 2.20.1