From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8012AC4CED1 for ; Thu, 3 Oct 2019 16:01:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C22921848 for ; Thu, 3 Oct 2019 16:01:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570118490; bh=m86mkQGEAR5Bc8tXq/FQ5/3j86C89hyMwVTi5kizTuA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=DyS9lBpCJfr4fOoYpjZQyqT1NzuuMR/gqJN2UcFboyPCJsX88hB750nW0Dpj2WR/x W+nkhW0BtP2HgTG6CiuYtW5Fkl0kUH+SzbpSkII1qXdKnuIKJ3s8PuEBMG3EO8eRL7 R6KLTjbWglTDurGCmaqheYxhbzsux57DzHRVJEgQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731804AbfJCQB3 (ORCPT ); Thu, 3 Oct 2019 12:01:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:45762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731797AbfJCQB2 (ORCPT ); Thu, 3 Oct 2019 12:01:28 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57FE120700; Thu, 3 Oct 2019 16:01:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570118487; bh=m86mkQGEAR5Bc8tXq/FQ5/3j86C89hyMwVTi5kizTuA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MyVMPtxNIFOrM2fCkHgnHiHjwtIXvGEQPF5CW5KgG4oGp4Wg4ekj1zYN+Qt942HPF aqRnRa/nSmrIrZjQNDzV43ThKKgzAel0SdGCF4hmobDwRXJM23UFa4N5sHFDJMAdlm /pm8mnAhJB0wkbq2gU3yPUDr8wyxBRUZsR4b8v8E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Li RongQing , Pravin B Shelar , "David S. Miller" Subject: [PATCH 4.9 028/129] openvswitch: change type of UPCALL_PID attribute to NLA_UNSPEC Date: Thu, 3 Oct 2019 17:52:31 +0200 Message-Id: <20191003154332.136509462@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154318.081116689@linuxfoundation.org> References: <20191003154318.081116689@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Li RongQing [ Upstream commit ea8564c865299815095bebeb4b25bef474218e4c ] userspace openvswitch patch "(dpif-linux: Implement the API functions to allow multiple handler threads read upcall)" changes its type from U32 to UNSPEC, but leave the kernel unchanged and after kernel 6e237d099fac "(netlink: Relax attr validation for fixed length types)", this bug is exposed by the below warning [ 57.215841] netlink: 'ovs-vswitchd': attribute type 5 has an invalid length. Fixes: 5cd667b0a456 ("openvswitch: Allow each vport to have an array of 'port_id's") Signed-off-by: Li RongQing Acked-by: Pravin B Shelar Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/openvswitch/datapath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c @@ -2218,7 +2218,7 @@ static const struct nla_policy vport_pol [OVS_VPORT_ATTR_STATS] = { .len = sizeof(struct ovs_vport_stats) }, [OVS_VPORT_ATTR_PORT_NO] = { .type = NLA_U32 }, [OVS_VPORT_ATTR_TYPE] = { .type = NLA_U32 }, - [OVS_VPORT_ATTR_UPCALL_PID] = { .type = NLA_U32 }, + [OVS_VPORT_ATTR_UPCALL_PID] = { .type = NLA_UNSPEC }, [OVS_VPORT_ATTR_OPTIONS] = { .type = NLA_NESTED }, };