From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCB18C32792 for ; Thu, 3 Oct 2019 16:02:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB8CC21848 for ; Thu, 3 Oct 2019 16:02:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570118529; bh=aGsvxcF3MiDOMIrZQmref9om6M8hirxqvJMiDcxDmJQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OAJ4B1j5z9IKu3KCwtC6r3aLuvhC3Sh3OW2oreC97MhbWTjrAebXSxgr4nmUu+TZT vL6K9UgiGlLZ3WxvncaEW+c9bXYC/sY4l/D+RSaRrPrjWESRQgif6WfkqYh1ArqJgS bEzpPdUBSsq2U1l/cR1jiyfhiYdR/LwyvCdN9j68= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729103AbfJCQCI (ORCPT ); Thu, 3 Oct 2019 12:02:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:46828 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729850AbfJCQCG (ORCPT ); Thu, 3 Oct 2019 12:02:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0D63A20700; Thu, 3 Oct 2019 16:02:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570118525; bh=aGsvxcF3MiDOMIrZQmref9om6M8hirxqvJMiDcxDmJQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1yNxxNJo16ijUH4j+qKFYIlUg6147TeeDaOwPRudaKTUrqpHe4yXwLFwo6T2Yr5xe FU3ObNJw6Ou2hiHHwLtHZRY5B98xys2ZcccZoPOcVJTrZ5ZGTDEKh1gkTJyl1F4Fpw U128erx0Q68jW0j3lb/kFF5cT4rgPd6Le4Z5JVbM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nick Stoughton , Pavel Machek , Jacek Anaszewski , Sasha Levin Subject: [PATCH 4.9 043/129] leds: leds-lp5562 allow firmware files up to the maximum length Date: Thu, 3 Oct 2019 17:52:46 +0200 Message-Id: <20191003154336.769210783@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154318.081116689@linuxfoundation.org> References: <20191003154318.081116689@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Nick Stoughton [ Upstream commit ed2abfebb041473092b41527903f93390d38afa7 ] Firmware files are in ASCII, using 2 hex characters per byte. The maximum length of a firmware string is therefore 16 (commands) * 2 (bytes per command) * 2 (characters per byte) = 64 Fixes: ff45262a85db ("leds: add new LP5562 LED driver") Signed-off-by: Nick Stoughton Acked-by: Pavel Machek Signed-off-by: Jacek Anaszewski Signed-off-by: Sasha Levin --- drivers/leds/leds-lp5562.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/leds/leds-lp5562.c b/drivers/leds/leds-lp5562.c index b75333803a637..9f5e4d04efad5 100644 --- a/drivers/leds/leds-lp5562.c +++ b/drivers/leds/leds-lp5562.c @@ -263,7 +263,11 @@ static void lp5562_firmware_loaded(struct lp55xx_chip *chip) { const struct firmware *fw = chip->fw; - if (fw->size > LP5562_PROGRAM_LENGTH) { + /* + * the firmware is encoded in ascii hex character, with 2 chars + * per byte + */ + if (fw->size > (LP5562_PROGRAM_LENGTH * 2)) { dev_err(&chip->cl->dev, "firmware data size overflow: %zu\n", fw->size); return; -- 2.20.1