From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23311C10F14 for ; Thu, 3 Oct 2019 16:08:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFD6F207FF for ; Thu, 3 Oct 2019 16:08:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570118887; bh=rK2Pf0xervn4YMl5Tev4jcEGHBlJ/S3B9WfVo1Gkftw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=wVqwzaP7WTbq6PIRv4Poq1XA61bJr7B5zjJzBxKE6D9FGNrDwPdzwdUOhlxCAYmwD 6BSRDkkjacYTghSEypOufht/fDVyMy+rXuK/+21V8cVTaOxR2eu+OR6RkS870HhP2G F1mE7Td29JyGzSWfNvjG4j5a/984jtNDRfJUh3Kw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731756AbfJCQIF (ORCPT ); Thu, 3 Oct 2019 12:08:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:55966 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733028AbfJCQH5 (ORCPT ); Thu, 3 Oct 2019 12:07:57 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F36F207FF; Thu, 3 Oct 2019 16:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570118876; bh=rK2Pf0xervn4YMl5Tev4jcEGHBlJ/S3B9WfVo1Gkftw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jl6A3NiXbwWTBqMczvP/3qdLXM6Z/J+Ill4OdAntyODhlAcIdU4Dbje2PoHqjhfbj tMmUQxms29Q/X6C4uj5nEgpOaABXbtfNNME0kYbB9DxskHkz57IRGoTOq//ghXTek6 JKXtlSBLUcO30jPG5xFcnS44LuCf7j6+Rf8/O+G4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Roderick Colenbrander , Jiri Kosina Subject: [PATCH 4.14 006/185] HID: sony: Fix memory corruption issue on cleanup. Date: Thu, 3 Oct 2019 17:51:24 +0200 Message-Id: <20191003154438.695963429@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154437.541662648@linuxfoundation.org> References: <20191003154437.541662648@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Roderick Colenbrander commit 2bcdacb70327013ca2066bfcf2af1009eff01f1d upstream. The sony driver is not properly cleaning up from potential failures in sony_input_configured. Currently it calls hid_hw_stop, while hid_connect is still running. This is not a good idea, instead hid_hw_stop should be moved to sony_probe. Similar changes were recently made to Logitech drivers, which were also doing improper cleanup. Signed-off-by: Roderick Colenbrander CC: stable@vger.kernel.org Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/hid/hid-sony.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/hid/hid-sony.c +++ b/drivers/hid/hid-sony.c @@ -2710,7 +2710,6 @@ err_stop: kfree(sc->output_report_dmabuf); sony_remove_dev_list(sc); sony_release_device_id(sc); - hid_hw_stop(hdev); return ret; } @@ -2772,6 +2771,7 @@ static int sony_probe(struct hid_device */ if (!(hdev->claimed & HID_CLAIMED_INPUT)) { hid_err(hdev, "failed to claim input\n"); + hid_hw_stop(hdev); return -ENODEV; }