From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E7EC32792 for ; Thu, 3 Oct 2019 17:35:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F00E20865 for ; Thu, 3 Oct 2019 17:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570124110; bh=t9LHanrfw5j5X4dy+qVtdNwC8YoU47sS5DxxzUcEG8I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xQw5G83+P3nn/K9uFRwqE1ZIa2bm7BQntmXCEkw4d4qYUBWf04Q1/5UoVMs8eaYP8 RS6l270wO7Vft493kF95VS51e/FcQYjukFvm18FvFHm4H7nX8Frb6+p+/xqqlB/Cjp nynvrWQh+PjnyHvpldQLVf3S+7+V3kEE6EryY1RE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731318AbfJCQGe (ORCPT ); Thu, 3 Oct 2019 12:06:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:53894 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732778AbfJCQGe (ORCPT ); Thu, 3 Oct 2019 12:06:34 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 28643207FF; Thu, 3 Oct 2019 16:06:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570118793; bh=t9LHanrfw5j5X4dy+qVtdNwC8YoU47sS5DxxzUcEG8I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kfE8Y69qza8TNbPpHjy+8QQhC8DeRjVv3qiZpH/nd0NyDHtaOtvWFUYwjR4ZSuwWk NsOI0YY1SxBAr+nUnw7GOkrAtuTeDyfIwq28XPPTsoAJKoGPJqMN5bMGPBa1kWMTu2 fFZzSm4J0xRBEW7+gPQZFBhMcUTGHalYkMKr+SOk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marco Felsch , Mauro Carvalho Chehab Subject: [PATCH 4.14 012/185] media: tvp5150: fix switch exit in set control handler Date: Thu, 3 Oct 2019 17:51:30 +0200 Message-Id: <20191003154439.976082404@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154437.541662648@linuxfoundation.org> References: <20191003154437.541662648@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Marco Felsch commit 2d29bcc8c237874795175b2930fa9a45a115175a upstream. The function only consists of a single switch case block without a default case. Unsupported control requests are indicated by the -EINVAL return code trough the last return statement at the end of the function. So exiting just the switch case block returns the -EINVAL error code but the hue control is supported and a zero should be returned instead. Replace the break by a 'return 0' to fix this behaviour. Fixes: d183e4efcae8 ("[media] v4l: tvp5150: Add missing break in set control handler") Signed-off-by: Marco Felsch Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/i2c/tvp5150.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/i2c/tvp5150.c +++ b/drivers/media/i2c/tvp5150.c @@ -827,7 +827,7 @@ static int tvp5150_s_ctrl(struct v4l2_ct return 0; case V4L2_CID_HUE: tvp5150_write(sd, TVP5150_HUE_CTL, ctrl->val); - break; + return 0; case V4L2_CID_TEST_PATTERN: decoder->enable = ctrl->val ? false : true; tvp5150_selmux(sd);