From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F7EDC4CED1 for ; Thu, 3 Oct 2019 17:35:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F58820862 for ; Thu, 3 Oct 2019 17:35:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570124101; bh=KmT45XMmaEV03FYR1vajtu4S+nbyzdKqf/cS2PEOZ2k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=pEmar98SkUbnJabr5HQ0r3tLxmWAZO3f+VxW4bopv0iXHQ+Z5zk7IajvZHEl0QRL7 G8kWwkhEdrszr5BlXqSksvmS/n3DTIJeEM1iPjs2150FIdNT2Dbjs/YqlN9pkJ0Cg3 +O1QSK2GGHMg+QwSeHO3mIg+Q/RmUvSbb1+DoMNY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731406AbfJCQGy (ORCPT ); Thu, 3 Oct 2019 12:06:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:54372 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732844AbfJCQGx (ORCPT ); Thu, 3 Oct 2019 12:06:53 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CA8DC207FF; Thu, 3 Oct 2019 16:06:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570118812; bh=KmT45XMmaEV03FYR1vajtu4S+nbyzdKqf/cS2PEOZ2k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ycOjKXKCBY3V2NKmXFUwfy2bDNWAHEERBkWAMRFghMLhmIPtGqI5yhzi59L98WB/K fZJixW9UqdM39Dzygo3ruG9Ej6eCMcrjdE3pKzy2S2U1hMZyyc6pnrZlYjuimjSViz SQoTCTsvT35o/fjz/xxB7K0CiIQsuqD8v7EBOcQM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, David Lechner , Sebastian Reichel , Sasha Levin Subject: [PATCH 4.14 019/185] power: supply: sysfs: ratelimit property read error message Date: Thu, 3 Oct 2019 17:51:37 +0200 Message-Id: <20191003154441.865274078@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154437.541662648@linuxfoundation.org> References: <20191003154437.541662648@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: David Lechner [ Upstream commit 87a2b65fc855e6be50f791c2ebbb492541896827 ] This adds rate limiting to the message that is printed when reading a power supply property via sysfs returns an error. This will prevent userspace applications from unintentionally dDOSing the system by continuously reading a property that returns an error. Signed-off-by: David Lechner Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/power_supply_sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c index eb5dc74820539..2ccaf4ff4be47 100644 --- a/drivers/power/supply/power_supply_sysfs.c +++ b/drivers/power/supply/power_supply_sysfs.c @@ -91,7 +91,8 @@ static ssize_t power_supply_show_property(struct device *dev, dev_dbg(dev, "driver has no data for `%s' property\n", attr->attr.name); else if (ret != -ENODEV && ret != -EAGAIN) - dev_err(dev, "driver failed to report `%s' property: %zd\n", + dev_err_ratelimited(dev, + "driver failed to report `%s' property: %zd\n", attr->attr.name, ret); return ret; } -- 2.20.1