From: Lee Jones <lee.jones@linaro.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-kernel@vger.kernel.org, d.schultz@phytec.de,
linux-rockchip@lists.infradead.org,
christoph.muellner@theobroma-systems.com,
tony.xie@rock-chips.com, stable@vger.kernel.org,
Elaine Zhang <zhangqing@rock-chips.com>,
Joseph Chen <chenjh@rock-chips.com>
Subject: Re: [PATCH 1/4] mfd: rk808: fix rk818 ID template
Date: Fri, 4 Oct 2019 12:55:46 +0100 [thread overview]
Message-ID: <20191004115546.GA18429@dell> (raw)
In-Reply-To: <20190917081256.24919-1-heiko@sntech.de>
On Tue, 17 Sep 2019, Heiko Stuebner wrote:
> From: Daniel Schultz <d.schultz@phytec.de>
>
> The Rockchip PMIC driver can automatically detect connected component
> versions by reading the ID_MSB and ID_LSB registers. The probe function
> will always fail with RK818 PMICs because the ID_MSK is 0xFFF0 and the
> RK818 template ID is 0x8181.
>
> This patch changes this value to 0x8180.
>
> Fixes: 9d6105e19f61 ("mfd: rk808: Fix up the chip id get failed")
> Cc: stable@vger.kernel.org
> Cc: Elaine Zhang <zhangqing@rock-chips.com>
> Cc: Joseph Chen <chenjh@rock-chips.com>
> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> [resend as it seems to have dropped on the floor]
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> include/linux/mfd/rk808.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2019-10-04 11:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 8:12 [PATCH 1/4] mfd: rk808: fix rk818 ID template Heiko Stuebner
2019-10-04 11:55 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004115546.GA18429@dell \
--to=lee.jones@linaro.org \
--cc=chenjh@rock-chips.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=d.schultz@phytec.de \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=tony.xie@rock-chips.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).