From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: chris@chris-wilson.co.uk, tvrtko.ursulin@intel.com,
stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] drm/i915/userptr: Acquire the page lock around" failed to apply to 4.19-stable tree
Date: Tue, 8 Oct 2019 20:40:12 -0400 [thread overview]
Message-ID: <20191009004012.GP1396@sasha-vm> (raw)
In-Reply-To: <157055550499113@kroah.com>
On Tue, Oct 08, 2019 at 07:25:04PM +0200, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.19-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From cb6d7c7dc7ff8cace666ddec66334117a6068ce2 Mon Sep 17 00:00:00 2001
>From: Chris Wilson <chris@chris-wilson.co.uk>
>Date: Mon, 8 Jul 2019 15:03:27 +0100
>Subject: [PATCH] drm/i915/userptr: Acquire the page lock around
> set_page_dirty()
>
>set_page_dirty says:
>
> For pages with a mapping this should be done under the page lock
> for the benefit of asynchronous memory errors who prefer a
> consistent dirty state. This rule can be broken in some special
> cases, but should be better not to.
>
>Under those rules, it is only safe for us to use the plain set_page_dirty
>calls for shmemfs/anonymous memory. Userptr may be used with real
>mappings and so needs to use the locked version (set_page_dirty_lock).
>
>Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=203317
>Fixes: 5cc9ed4b9a7a ("drm/i915: Introduce mapping of user pages into video memory (userptr) ioctl")
>References: 6dcc693bc57f ("ext4: warn when page is dirtied without buffers")
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>Cc: stable@vger.kernel.org
>Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>Link: https://patchwork.freedesktop.org/patch/msgid/20190708140327.26825-1-chris@chris-wilson.co.uk
File got moved around. I've fixed it up and queued for 4.19-4.4.
--
Thanks,
Sasha
next prev parent reply other threads:[~2019-10-09 0:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 17:25 FAILED: patch "[PATCH] drm/i915/userptr: Acquire the page lock around" failed to apply to 4.19-stable tree gregkh
2019-10-09 0:40 ` Sasha Levin [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-08-05 5:57 gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009004012.GP1396@sasha-vm \
--to=sashal@kernel.org \
--cc=chris@chris-wilson.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).