From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A81F6C4360C for ; Thu, 10 Oct 2019 08:47:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 78EAD218AC for ; Thu, 10 Oct 2019 08:47:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570697268; bh=2IvRCIuTDFsSrODDhJpeFt6bL0Q/jSd/PXyjIVZ2fNk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1czrca9htWkXNxHfnZKAqHysw6H1VZP7j5WdD/50GmAffkGkNIm+QACJIreE/Zy9K +Jz+q+pULaDzbzyVIrRifWbPIkwCrcWhz6OtWa4+DQmSBozAY3v6Itbp8w/q2ktoGB rfDd+Q0mMRuH2+aCQ3RkQsFQETCZ9DFrpKm3UNzw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388306AbfJJIrr (ORCPT ); Thu, 10 Oct 2019 04:47:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:53822 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389490AbfJJIro (ORCPT ); Thu, 10 Oct 2019 04:47:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8829B21929; Thu, 10 Oct 2019 08:47:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570697264; bh=2IvRCIuTDFsSrODDhJpeFt6bL0Q/jSd/PXyjIVZ2fNk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pntox7tm1cWb3zkQkRomvartpr9zLc3zwraZw4pY1G9l8sYWj1ftIWr5Ea8AByjoD YTiMgaEXJzQrEJDQcJoirafxxVZfDrkhST9hbapH1RAgIP6KCymvPIEUttDHDHCNHQ gLP1b6YFb5v/WE8HtsuQbpQYgBbmeEAd5CNpvT7Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost , Jakub Kicinski , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 076/114] nfp: flower: fix memory leak in nfp_flower_spawn_vnic_reprs Date: Thu, 10 Oct 2019 10:36:23 +0200 Message-Id: <20191010083611.968665805@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191010083544.711104709@linuxfoundation.org> References: <20191010083544.711104709@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Navid Emamdoost [ Upstream commit 8ce39eb5a67aee25d9f05b40b673c95b23502e3e ] In nfp_flower_spawn_vnic_reprs in the loop if initialization or the allocations fail memory is leaked. Appropriate releases are added. Fixes: b94524529741 ("nfp: flower: add per repr private data for LAG offload") Signed-off-by: Navid Emamdoost Acked-by: Jakub Kicinski Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/netronome/nfp/flower/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.c b/drivers/net/ethernet/netronome/nfp/flower/main.c index 22c572a09b320..c19e88efe958d 100644 --- a/drivers/net/ethernet/netronome/nfp/flower/main.c +++ b/drivers/net/ethernet/netronome/nfp/flower/main.c @@ -272,6 +272,7 @@ nfp_flower_spawn_vnic_reprs(struct nfp_app *app, port = nfp_port_alloc(app, port_type, repr); if (IS_ERR(port)) { err = PTR_ERR(port); + kfree(repr_priv); nfp_repr_free(repr); goto err_reprs_clean; } -- 2.20.1