* [PATCH 0/2] xen/netback: bug fix and cleanup
@ 2019-10-14 9:09 Juergen Gross
2019-10-14 9:09 ` [PATCH 1/2] xen/netback: fix error path of xenvif_connect_data() Juergen Gross
2019-10-16 1:19 ` [PATCH 0/2] xen/netback: bug fix and cleanup David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Juergen Gross @ 2019-10-14 9:09 UTC (permalink / raw)
To: xen-devel, netdev, linux-kernel
Cc: Juergen Gross, Wei Liu, Paul Durrant, David S. Miller, # 3 . 12
One bugfix (patch 1) I stumbled over while doing a cleanup (patch 2)
of the xen-netback init/deinit code.
Juergen Gross (2):
xen/netback: fix error path of xenvif_connect_data()
xen/netback: cleanup init and deinit code
drivers/net/xen-netback/interface.c | 115 +++++++++++++++++-------------------
1 file changed, 54 insertions(+), 61 deletions(-)
--
2.16.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] xen/netback: fix error path of xenvif_connect_data()
2019-10-14 9:09 [PATCH 0/2] xen/netback: bug fix and cleanup Juergen Gross
@ 2019-10-14 9:09 ` Juergen Gross
2019-10-14 10:11 ` Paul Durrant
2019-10-16 1:19 ` [PATCH 0/2] xen/netback: bug fix and cleanup David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Juergen Gross @ 2019-10-14 9:09 UTC (permalink / raw)
To: xen-devel, netdev, linux-kernel
Cc: Juergen Gross, Wei Liu, Paul Durrant, David S. Miller, stable
xenvif_connect_data() calls module_put() in case of error. This is
wrong as there is no related module_get().
Remove the superfluous module_put().
Fixes: 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down")
Cc: <stable@vger.kernel.org> # 3.12
Signed-off-by: Juergen Gross <jgross@suse.com>
---
drivers/net/xen-netback/interface.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
index 240f762b3749..103ed00775eb 100644
--- a/drivers/net/xen-netback/interface.c
+++ b/drivers/net/xen-netback/interface.c
@@ -719,7 +719,6 @@ int xenvif_connect_data(struct xenvif_queue *queue,
xenvif_unmap_frontend_data_rings(queue);
netif_napi_del(&queue->napi);
err:
- module_put(THIS_MODULE);
return err;
}
--
2.16.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] xen/netback: fix error path of xenvif_connect_data()
2019-10-14 9:09 ` [PATCH 1/2] xen/netback: fix error path of xenvif_connect_data() Juergen Gross
@ 2019-10-14 10:11 ` Paul Durrant
0 siblings, 0 replies; 4+ messages in thread
From: Paul Durrant @ 2019-10-14 10:11 UTC (permalink / raw)
To: Juergen Gross
Cc: xen-devel, netdev, linux-kernel, Wei Liu, Paul Durrant,
David S. Miller, stable
On Mon, 14 Oct 2019 at 10:09, Juergen Gross <jgross@suse.com> wrote:
>
> xenvif_connect_data() calls module_put() in case of error. This is
> wrong as there is no related module_get().
>
> Remove the superfluous module_put().
>
> Fixes: 279f438e36c0a7 ("xen-netback: Don't destroy the netdev until the vif is shut down")
> Cc: <stable@vger.kernel.org> # 3.12
> Signed-off-by: Juergen Gross <jgross@suse.com>
Yes, looks like this should have been cleaned up a long time ago.
Reviewed-by: Paul Durrant <paul@xen.org>
> ---
> drivers/net/xen-netback/interface.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
> index 240f762b3749..103ed00775eb 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -719,7 +719,6 @@ int xenvif_connect_data(struct xenvif_queue *queue,
> xenvif_unmap_frontend_data_rings(queue);
> netif_napi_del(&queue->napi);
> err:
> - module_put(THIS_MODULE);
> return err;
> }
>
> --
> 2.16.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] xen/netback: bug fix and cleanup
2019-10-14 9:09 [PATCH 0/2] xen/netback: bug fix and cleanup Juergen Gross
2019-10-14 9:09 ` [PATCH 1/2] xen/netback: fix error path of xenvif_connect_data() Juergen Gross
@ 2019-10-16 1:19 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2019-10-16 1:19 UTC (permalink / raw)
To: jgross; +Cc: xen-devel, netdev, linux-kernel, wei.liu, paul, stable
From: Juergen Gross <jgross@suse.com>
Date: Mon, 14 Oct 2019 11:09:08 +0200
> One bugfix (patch 1) I stumbled over while doing a cleanup (patch 2)
> of the xen-netback init/deinit code.
Please do not mix cleanups and genuine bug fixes.
Submit the bug fix targetting the 'net' GIT tree, and once that eventually
gets merged into 'net-next' you can submit the cleanup against that.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-16 1:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-14 9:09 [PATCH 0/2] xen/netback: bug fix and cleanup Juergen Gross
2019-10-14 9:09 ` [PATCH 1/2] xen/netback: fix error path of xenvif_connect_data() Juergen Gross
2019-10-14 10:11 ` Paul Durrant
2019-10-16 1:19 ` [PATCH 0/2] xen/netback: bug fix and cleanup David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).