From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: ak@it-klinger.de, Jonathan.Cameron@huawei.com, Stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] iio: adc: hx711: fix bug in sampling of data" failed to apply to 4.14-stable tree
Date: Mon, 14 Oct 2019 20:57:33 -0400 [thread overview]
Message-ID: <20191015005733.GH31224@sasha-vm> (raw)
In-Reply-To: <15710652867196@kroah.com>
On Mon, Oct 14, 2019 at 05:01:26PM +0200, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.14-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From 4043ecfb5fc4355a090111e14faf7945ff0fdbd5 Mon Sep 17 00:00:00 2001
>From: Andreas Klinger <ak@it-klinger.de>
>Date: Mon, 9 Sep 2019 14:37:21 +0200
>Subject: [PATCH] iio: adc: hx711: fix bug in sampling of data
>
>Fix bug in sampling function hx711_cycle() when interrupt occures while
>PD_SCK is high. If PD_SCK is high for at least 60 us power down mode of
>the sensor is entered which in turn leads to a wrong measurement.
>
>Switch off interrupts during a PD_SCK high period and move query of DOUT
>to the latest point of time which is at the end of PD_SCK low period.
>
>This bug exists in the driver since it's initial addition. The more
>interrupts on the system the higher is the probability that it happens.
>
>Fixes: c3b2fdd0ea7e ("iio: adc: hx711: Add IIO driver for AVIA HX711")
>Signed-off-by: Andreas Klinger <ak@it-klinger.de>
>Cc: <Stable@vger.kernel.org>
>Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
I've queued up this patch in addition: 461631face580 ("iio: hx711: add
delay until DOUT is ready") and queued both for 4.14. It's not needed on
older kernels.
--
Thanks,
Sasha
prev parent reply other threads:[~2019-10-15 0:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 15:01 FAILED: patch "[PATCH] iio: adc: hx711: fix bug in sampling of data" failed to apply to 4.14-stable tree gregkh
2019-10-15 0:57 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015005733.GH31224@sasha-vm \
--to=sashal@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=Stable@vger.kernel.org \
--cc=ak@it-klinger.de \
--cc=gregkh@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).