From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38A8CECE599 for ; Wed, 16 Oct 2019 22:07:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0750B2168B for ; Wed, 16 Oct 2019 22:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263661; bh=noUnwI0h4iur9WPeS9k/FiH/dWk7jZpKt2XyMsjckl8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=wVs7i26AhhiW+IRGHGk6Px8V/urBQg9qiK0lCkfi2U4SZy4G0wcxV/l9cZm+3w+uV c/FG4tl26+z5wOQcUG9t8XNN/1+WVDZUPHt580nnliioQkb3as7QnPvi/wYqisXsyH 8N9UTalmZhmjxS/BvYu/m2rEI27dYf3Pb7lXCwCM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389620AbfJPWHg (ORCPT ); Wed, 16 Oct 2019 18:07:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:51350 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728605AbfJPV6G (ORCPT ); Wed, 16 Oct 2019 17:58:06 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F1C1921D7D; Wed, 16 Oct 2019 21:58:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263086; bh=noUnwI0h4iur9WPeS9k/FiH/dWk7jZpKt2XyMsjckl8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ERd13f7Qh6ve71C2CkXl/FG8eXc37w1uYZHfaatnkoFOyfDcjXXYsnBJc+bRaFNW4 0Dn6UD972M7nZRnWtompoAg8kTwaXuWSd/cpN3/zVrhgnpudvQdXzMf+Sdg4OXJ/jR +qA/PBRPzlwNlttBh/6aAQ0cY+JyM7oxrVTAK66w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost Subject: [PATCH 4.19 44/81] staging: vt6655: Fix memory leak in vt6655_probe Date: Wed, 16 Oct 2019 14:50:55 -0700 Message-Id: <20191016214839.038246940@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214805.727399379@linuxfoundation.org> References: <20191016214805.727399379@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Navid Emamdoost commit 80b15db5e1e9c3300de299b2d43d1aafb593e6ac upstream. In vt6655_probe, if vnt_init() fails the cleanup code needs to be called like other error handling cases. The call to device_free_info() is added. Fixes: 67013f2c0e58 ("staging: vt6655: mac80211 conversion add main mac80211 functions") Signed-off-by: Navid Emamdoost Cc: stable Link: https://lore.kernel.org/r/20191004200319.22394-1-navid.emamdoost@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/vt6655/device_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -1755,8 +1755,10 @@ vt6655_probe(struct pci_dev *pcid, const priv->hw->max_signal = 100; - if (vnt_init(priv)) + if (vnt_init(priv)) { + device_free_info(priv); return -ENODEV; + } device_print_info(priv); pci_set_drvdata(pcid, priv);