From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E81EFA372B for ; Wed, 16 Oct 2019 22:02:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D8B4218DE for ; Wed, 16 Oct 2019 22:02:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263352; bh=BykSuC2M0KsUSDjDN+Qux96Y+qA/cbufw6DyvJBIPU0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Af9EZ9FhhUvmLqBWsHg7YydZmhlhpldZMZUHVLZOvoD3vSVsdfkGWeUKvopGJvYtE LWSr/Znbv8KASSDG2etJJS5kKSOCZdAxR4a1vjvP+UYjtEIiNLqkDh08A6M7gpou27 UXtMfmDoIly0ejzw+CbYFM6eFFBi8IqcJ2mcTqdc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439004AbfJPWC0 (ORCPT ); Wed, 16 Oct 2019 18:02:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:54888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438611AbfJPV7o (ORCPT ); Wed, 16 Oct 2019 17:59:44 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F986222C5; Wed, 16 Oct 2019 21:59:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263184; bh=BykSuC2M0KsUSDjDN+Qux96Y+qA/cbufw6DyvJBIPU0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V2vGkloXXPt4744b1CUxKC3MOtGztMKwG6KDgk0t636Rkx/s2r+i2ayOAyiTsBt0k A8wwy1GxKPvjkbg3CmfZePQwZQB7awg1jrP8D05x4ba99uJ95tB1+CECEaSgsfiYWd D4ZbfND0H6BSDGc+Sbq1nd9LzeKYEYvyqWlA/aOk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Ard Biesheuvel , Jerry Snitselaar , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , kernel-janitors@vger.kernel.org, linux-efi@vger.kernel.org, Ingo Molnar Subject: [PATCH 5.3 111/112] efi/tpm: Fix sanity check of unsigned tbl_size being less than zero Date: Wed, 16 Oct 2019 14:51:43 -0700 Message-Id: <20191016214907.521785772@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214844.038848564@linuxfoundation.org> References: <20191016214844.038848564@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Colin Ian King commit be59d57f98065af0b8472f66a0a969207b168680 upstream. Currently the check for tbl_size being less than zero is always false because tbl_size is unsigned. Fix this by making it a signed int. Addresses-Coverity: ("Unsigned compared against 0") Signed-off-by: Colin Ian King Cc: Ard Biesheuvel Cc: Jerry Snitselaar Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: kernel-janitors@vger.kernel.org Cc: linux-efi@vger.kernel.org Fixes: e658c82be556 ("efi/tpm: Only set 'efi_tpm_final_log_size' after successful event log parsing") Link: https://lkml.kernel.org/r/20191008100153.8499-1-colin.king@canonical.com Signed-off-by: Ingo Molnar Signed-off-by: Greg Kroah-Hartman --- drivers/firmware/efi/tpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/firmware/efi/tpm.c +++ b/drivers/firmware/efi/tpm.c @@ -40,7 +40,7 @@ int __init efi_tpm_eventlog_init(void) { struct linux_efi_tpm_eventlog *log_tbl; struct efi_tcg2_final_events_table *final_tbl; - unsigned int tbl_size; + int tbl_size; int ret = 0; if (efi.tpm_log == EFI_INVALID_TABLE_ADDR) {