From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EAB6CA9EA9 for ; Fri, 18 Oct 2019 22:03:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 429D6222C2 for ; Fri, 18 Oct 2019 22:03:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571436221; bh=/bed9kQ9wctSWQIEVWMoM3vLii4+hyghZGfFJWUIRk8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=DiEtB+QSsG+yp64OUpXdAp688SeunDd2qfQVNHtmewX/cdfytAhjtJwX5muktEjkN kCs8XzbHosO9lr0XakiXDvZKzncBhCxImONfCJpis7/GG3UGEO4kdpEXlFN3mbZwiT U3XmR53AA1ATuiyE/SMXdT3Wcz2AbQ5Tp31rDf74= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726962AbfJRWDk (ORCPT ); Fri, 18 Oct 2019 18:03:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:35078 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727136AbfJRWDj (ORCPT ); Fri, 18 Oct 2019 18:03:39 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D8C99222C6; Fri, 18 Oct 2019 22:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571436219; bh=/bed9kQ9wctSWQIEVWMoM3vLii4+hyghZGfFJWUIRk8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H/17eZX3WsQTrYCYgdjEBpa96tqMnfQievLLP/jNojFi+0BMn087JTgm007ygwBWt q4BzoOMpkk1rZL86P5gd/O860pIySFzgFoOaic1ahHySvKZLrBHFNKaG/Fubgh2Gpd Tjdc7Re3QHbRlZJdxAQrxIEudeyA+aaZXMTuAHKk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Arnaldo Carvalho de Melo , Russell King - ARM Linux admin , Adrian Hunter , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Peter Zijlstra , Will Deacon , Sasha Levin Subject: [PATCH AUTOSEL 5.3 09/89] perf annotate: Propagate perf_env__arch() error Date: Fri, 18 Oct 2019 18:02:04 -0400 Message-Id: <20191018220324.8165-9-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191018220324.8165-1-sashal@kernel.org> References: <20191018220324.8165-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnaldo Carvalho de Melo [ Upstream commit a66fa0619a0ae3585ef09e9c33ecfb5c7c6cb72b ] The callers of symbol__annotate2() use symbol__strerror_disassemble() to convert its failure returns into a human readable string, so propagate error values from functions it calls, starting with perf_env__arch() that when fails the right thing to do is to look at 'errno' to see why its possible call to uname() failed. Reported-by: Russell King - ARM Linux admin Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Cc: Peter Zijlstra , Cc: Will Deacon Link: https://lkml.kernel.org/n/tip-it5d83kyusfhb1q1b0l4pxzs@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/util/annotate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index 163536720149b..6d9642c082e52 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c @@ -2065,7 +2065,7 @@ int symbol__annotate(struct symbol *sym, struct map *map, int err; if (!arch_name) - return -1; + return errno; args.arch = arch = arch__find(arch_name); if (arch == NULL) -- 2.20.1