From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29575CA9EAF for ; Sun, 27 Oct 2019 21:30:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8082205C9 for ; Sun, 27 Oct 2019 21:30:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211859; bh=dIhYXqC6zsENCqrC+i8wUr7eKSJQEN4dFD25TriTo3k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PCJ/dJq3DRN+mA6/DjxpmnNy9kAZlRJ7Yu/DnuH7aphJl16Rvrkv/Fq7O0TPGW6OH enAkmtxDdmRziJhS0VPLQFG5fX8Id4BnGyOkKAD+dTGML/n8Oqu+EQ4S76PQcqKeY7 2J76qmM8kpFn08GplscTm/yOSmsUs0Iup5DyVBMg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731158AbfJ0VSA (ORCPT ); Sun, 27 Oct 2019 17:18:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:38036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731189AbfJ0VR7 (ORCPT ); Sun, 27 Oct 2019 17:17:59 -0400 Received: from localhost (100.50.158.77.rev.sfr.net [77.158.50.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8D20521783; Sun, 27 Oct 2019 21:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572211078; bh=dIhYXqC6zsENCqrC+i8wUr7eKSJQEN4dFD25TriTo3k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xYhGSP44w0VeCqzyLfd7MeiCp8cCao2QideoMGG5+wST55IzcbYHjXPSMJWhzuI5+ +HiBHIB/R3B1kSLcwjCw0ODeF+LzBgt9a8vgHr1G1diP6F7vuyURQmL5E0jak1TwTf kUjKZvgDOvZ6U0KqP7DXTXX5hcXDEnxfacXEwIp8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost , "James Qian Wang (Arm Technology China)" , Sasha Levin Subject: [PATCH 5.3 024/197] drm/komeda: prevent memory leak in komeda_wb_connector_add Date: Sun, 27 Oct 2019 21:59:02 +0100 Message-Id: <20191027203352.994952769@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191027203351.684916567@linuxfoundation.org> References: <20191027203351.684916567@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Navid Emamdoost [ Upstream commit a0ecd6fdbf5d648123a7315c695fb6850d702835 ] In komeda_wb_connector_add if drm_writeback_connector_init fails the allocated memory for kwb_conn should be released. Signed-off-by: Navid Emamdoost Reviewed-by: James Qian Wang (Arm Technology China) Signed-off-by: james qian wang (Arm Technology China) Link: https://patchwork.freedesktop.org/patch/msgid/20190925043031.32308-1-navid.emamdoost@gmail.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c index 23fbee268119f..b72840c06ab76 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c @@ -165,8 +165,10 @@ static int komeda_wb_connector_add(struct komeda_kms_dev *kms, &komeda_wb_encoder_helper_funcs, formats, n_formats); komeda_put_fourcc_list(formats); - if (err) + if (err) { + kfree(kwb_conn); return err; + } drm_connector_helper_add(&wb_conn->base, &komeda_wb_conn_helper_funcs); -- 2.20.1