From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: wqu@suse.com, dsterba@suse.com, nborisov@suse.com,
stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] btrfs: tracepoints: Fix wrong parameter order for qgroup" failed to apply to 4.19-stable tree
Date: Mon, 28 Oct 2019 11:21:57 -0400 [thread overview]
Message-ID: <20191028152157.GC1554@sasha-vm> (raw)
In-Reply-To: <157219129664247@kroah.com>
On Sun, Oct 27, 2019 at 04:48:16PM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.19-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From fd2b007eaec898564e269d1f478a2da0380ecf51 Mon Sep 17 00:00:00 2001
>From: Qu Wenruo <wqu@suse.com>
>Date: Thu, 17 Oct 2019 10:38:36 +0800
>Subject: [PATCH] btrfs: tracepoints: Fix wrong parameter order for qgroup
> events
>
>[BUG]
>For btrfs:qgroup_meta_reserve event, the trace event can output garbage:
>
> qgroup_meta_reserve: 9c7f6acc-b342-4037-bc47-7f6e4d2232d7: refroot=5(FS_TREE) type=DATA diff=2
>
>The diff should always be alinged to sector size (4k), so there is
>definitely something wrong.
>
>[CAUSE]
>For the wrong @diff, it's caused by wrong parameter order.
>The correct parameters are:
>
> struct btrfs_root, s64 diff, int type.
>
>However the parameters used are:
>
> struct btrfs_root, int type, s64 diff.
>
>Fixes: 4ee0d8832c2e ("btrfs: qgroup: Update trace events for metadata reservation")
>CC: stable@vger.kernel.org # 4.19+
>Reviewed-by: Nikolay Borisov <nborisov@suse.com>
>Signed-off-by: Qu Wenruo <wqu@suse.com>
>Reviewed-by: David Sterba <dsterba@suse.com>
>Signed-off-by: David Sterba <dsterba@suse.com>
Just needed some love to work around missing 4fd786e6c3d67 ("btrfs:
Remove 'objectid' member from struct btrfs_root"). Queued up for 4.19.
--
Thanks,
Sasha
next prev parent reply other threads:[~2019-10-28 15:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 15:48 FAILED: patch "[PATCH] btrfs: tracepoints: Fix wrong parameter order for qgroup" failed to apply to 4.19-stable tree gregkh
2019-10-28 15:21 ` Sasha Levin [this message]
2019-10-29 1:38 ` Qu WenRuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028152157.GC1554@sasha-vm \
--to=sashal@kernel.org \
--cc=dsterba@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=nborisov@suse.com \
--cc=stable@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).