From: Sasha Levin <sashal@kernel.org>
To: David Hildenbrand <david@redhat.com>
Cc: gregkh@linuxfoundation.org, akpm@linux-foundation.org,
mhocko@kernel.org, n-horiguchi@ah.jp.nec.com,
stable@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: FAILED: patch "[PATCH] mm/memory-failure.c: don't access uninitialized memmaps in" failed to apply to 4.14-stable tree
Date: Mon, 28 Oct 2019 11:39:40 -0400 [thread overview]
Message-ID: <20191028153940.GE1554@sasha-vm> (raw)
In-Reply-To: <a2defc30-700f-724f-7e59-fb1af9a528d5@redhat.com>
On Mon, Oct 28, 2019 at 04:07:10PM +0100, David Hildenbrand wrote:
>On 28.10.19 09:44, Sasha Levin wrote:
>>On Sun, Oct 27, 2019 at 02:41:31PM +0100, gregkh@linuxfoundation.org wrote:
>>>
>>>The patch below does not apply to the 4.14-stable tree.
>>>If someone wants it applied there, or to any other stable or longterm
>>>tree, then please email the backport, including the original git commit
>>>id to <stable@vger.kernel.org>.
>>>
>>>thanks,
>>>
>>>greg k-h
>>>
>>>------------------ original commit in Linus's tree ------------------
>>>
>>>From 96c804a6ae8c59a9092b3d5dd581198472063184 Mon Sep 17 00:00:00 2001
>>>From: David Hildenbrand <david@redhat.com>
>>>Date: Fri, 18 Oct 2019 20:19:23 -0700
>>>Subject: [PATCH] mm/memory-failure.c: don't access uninitialized memmaps in
>>>memory_failure()
>>>
>>>We should check for pfn_to_online_page() to not access uninitialized
>>>memmaps. Reshuffle the code so we don't have to duplicate the error
>>>message.
>>>
>>>Link: http://lkml.kernel.org/r/20191009142435.3975-3-david@redhat.com
>>>Signed-off-by: David Hildenbrand <david@redhat.com>
>>>Fixes: f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded memory to zones until online") [visible after d0dc12e86b319]
>>>Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
>>>Cc: Michal Hocko <mhocko@kernel.org>
>>>Cc: <stable@vger.kernel.org> [4.13+]
>>>Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>>>Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
>>
>>I took in 83b57531c58f4 ("mm/memory_failure: Remove unused trapno from
>>memory_failure") for 4.14 to address this.
>>
>
>I guess that shouldn't be sufficient as we are missing the whole
>devmap stuff? (at least not sufficient to cleanly cherry pick this
>patch)
>
>The backport should be very simple, though. Did you already perform
>the backport or shall I send one?
I did it, thank you :)
--
Thanks,
Sasha
prev parent reply other threads:[~2019-10-28 15:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 13:41 FAILED: patch "[PATCH] mm/memory-failure.c: don't access uninitialized memmaps in" failed to apply to 4.14-stable tree gregkh
2019-10-28 8:44 ` Sasha Levin
2019-10-28 15:07 ` David Hildenbrand
2019-10-28 15:39 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028153940.GE1554@sasha-vm \
--to=sashal@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=mhocko@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).