From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C1E1CA9EC1 for ; Mon, 28 Oct 2019 15:39:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E588F21721 for ; Mon, 28 Oct 2019 15:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572277185; bh=JWMG471djI5AQdmhMQRZxEcTAXjah/fH04xzSKvNIsE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jK6c+XQMKiczcenag1CZms5KjJmkXaowlaiga4ukSiM8J9JgcLHxZ21gyWDm5Vosf pjviM/hizD9sV7uCr2KyPt8EjxIavCDWdtJJllpxaleVbfuEO3fMzVGTKynUv++8dg VmNfk53RgdKnoKJQXZ1xiimN+G3dL4Y1YlLI1rl0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389679AbfJ1Pjo (ORCPT ); Mon, 28 Oct 2019 11:39:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:56406 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726025AbfJ1Pjo (ORCPT ); Mon, 28 Oct 2019 11:39:44 -0400 Received: from localhost (unknown [91.217.168.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BA714208C0; Mon, 28 Oct 2019 15:39:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572277183; bh=JWMG471djI5AQdmhMQRZxEcTAXjah/fH04xzSKvNIsE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uNgeYTD1tlEYEeE7Lk2068C1t1RYjlQTXhhkFzOBzapNd4bSVV2O3NwtzKeG2Polo 2PU4v7rtDtDWFvnzohSTHuZFH9fgBioLmrjdu9ulLPD9Fb8m51nD5NwyyTxzPu1CV9 3IrrH6J4Ux64Yle0Dio+qj/SWhMfjLwsutI6yRDU= Date: Mon, 28 Oct 2019 11:39:40 -0400 From: Sasha Levin To: David Hildenbrand Cc: gregkh@linuxfoundation.org, akpm@linux-foundation.org, mhocko@kernel.org, n-horiguchi@ah.jp.nec.com, stable@vger.kernel.org, torvalds@linux-foundation.org Subject: Re: FAILED: patch "[PATCH] mm/memory-failure.c: don't access uninitialized memmaps in" failed to apply to 4.14-stable tree Message-ID: <20191028153940.GE1554@sasha-vm> References: <1572183691251118@kroah.com> <20191028084457.GJ1560@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Oct 28, 2019 at 04:07:10PM +0100, David Hildenbrand wrote: >On 28.10.19 09:44, Sasha Levin wrote: >>On Sun, Oct 27, 2019 at 02:41:31PM +0100, gregkh@linuxfoundation.org wrote: >>> >>>The patch below does not apply to the 4.14-stable tree. >>>If someone wants it applied there, or to any other stable or longterm >>>tree, then please email the backport, including the original git commit >>>id to . >>> >>>thanks, >>> >>>greg k-h >>> >>>------------------ original commit in Linus's tree ------------------ >>> >>>>From 96c804a6ae8c59a9092b3d5dd581198472063184 Mon Sep 17 00:00:00 2001 >>>From: David Hildenbrand >>>Date: Fri, 18 Oct 2019 20:19:23 -0700 >>>Subject: [PATCH] mm/memory-failure.c: don't access uninitialized memmaps in >>>memory_failure() >>> >>>We should check for pfn_to_online_page() to not access uninitialized >>>memmaps. Reshuffle the code so we don't have to duplicate the error >>>message. >>> >>>Link: http://lkml.kernel.org/r/20191009142435.3975-3-david@redhat.com >>>Signed-off-by: David Hildenbrand >>>Fixes: f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded memory to zones until online") [visible after d0dc12e86b319] >>>Acked-by: Naoya Horiguchi >>>Cc: Michal Hocko >>>Cc: [4.13+] >>>Signed-off-by: Andrew Morton >>>Signed-off-by: Linus Torvalds >> >>I took in 83b57531c58f4 ("mm/memory_failure: Remove unused trapno from >>memory_failure") for 4.14 to address this. >> > >I guess that shouldn't be sufficient as we are missing the whole >devmap stuff? (at least not sufficient to cleanly cherry pick this >patch) > >The backport should be very simple, though. Did you already perform >the backport or shall I send one? I did it, thank you :) -- Thanks, Sasha