From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7016BC5DF60 for ; Fri, 8 Nov 2019 16:59:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C3CE2178F for ; Fri, 8 Nov 2019 16:59:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726152AbfKHQ7W (ORCPT ); Fri, 8 Nov 2019 11:59:22 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:44304 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726199AbfKHQ7W (ORCPT ); Fri, 8 Nov 2019 11:59:22 -0500 Received: from [179.174.16.153] (helo=calabresa) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iT7bU-0000Hs-DW; Fri, 08 Nov 2019 16:59:20 +0000 Date: Fri, 8 Nov 2019 13:59:16 -0300 From: Thadeu Lima de Souza Cascardo To: Petr Vorel Cc: stable@vger.kernel.org, Thomas Gleixner , Ben Hutchings Subject: Re: [PATCH v3.16] alarmtimer: Use EOPNOTSUPP instead of ENOTSUPP Message-ID: <20191108165916.GD3753@calabresa> References: <20191108155411.13306-1-pvorel@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191108155411.13306-1-pvorel@suse.cz> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, Nov 08, 2019 at 04:54:11PM +0100, Petr Vorel wrote: > From: Thadeu Lima de Souza Cascardo > > ENOTSUPP is not supposed to be returned to userspace. This was found on an > OpenPower machine, where the RTC does not support set_alarm. > > On that system, a clock_nanosleep(CLOCK_REALTIME_ALARM, ...) results in > "524 Unknown error 524" > > Replace it with EOPNOTSUPP which results in the expected "95 Operation not > supported" error. > > Fixes: 1c6b39ad3f01 (alarmtimers: Return -ENOTSUPP if no RTC device is present) > Signed-off-by: Thadeu Lima de Souza Cascardo > Signed-off-by: Thomas Gleixner > [ pvorel: backport for v3.16, changes also in alarm_timer_{del,set}(), which > were removed in f2c45807d3992fe0f173f34af9c347d907c31686 in v4.13-rc1 ] > Signed-off-by: Petr Vorel > Cc: stable@vger.kernel.org # v3.16 > Cc: Thadeu Lima de Souza Cascardo This already has my sign-off, but for the extra changes: Acked-by: Thadeu Lima de Souza Cascardo > Cc: Ben Hutchings > Link: https://lkml.kernel.org/r/20190903171802.28314-1-cascardo@canonical.com > --- > kernel/time/alarmtimer.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c > index 8c65c236f26a..c3fc69986850 100644 > --- a/kernel/time/alarmtimer.c > +++ b/kernel/time/alarmtimer.c > @@ -533,7 +533,7 @@ static int alarm_timer_create(struct k_itimer *new_timer) > struct alarm_base *base; > > if (!alarmtimer_get_rtcdev()) > - return -ENOTSUPP; > + return -EOPNOTSUPP; > > if (!capable(CAP_WAKE_ALARM)) > return -EPERM; > @@ -576,7 +576,7 @@ static void alarm_timer_get(struct k_itimer *timr, > static int alarm_timer_del(struct k_itimer *timr) > { > if (!rtcdev) > - return -ENOTSUPP; > + return -EOPNOTSUPP; > > if (alarm_try_to_cancel(&timr->it.alarm.alarmtimer) < 0) > return TIMER_RETRY; > @@ -600,7 +600,7 @@ static int alarm_timer_set(struct k_itimer *timr, int flags, > ktime_t exp; > > if (!rtcdev) > - return -ENOTSUPP; > + return -EOPNOTSUPP; > > if (flags & ~TIMER_ABSTIME) > return -EINVAL; > @@ -761,7 +761,7 @@ static int alarm_timer_nsleep(const clockid_t which_clock, int flags, > struct restart_block *restart; > > if (!alarmtimer_get_rtcdev()) > - return -ENOTSUPP; > + return -EOPNOTSUPP; > > if (flags & ~TIMER_ABSTIME) > return -EINVAL;