From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85F38C17440 for ; Sun, 10 Nov 2019 03:06:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 50A96215EA for ; Sun, 10 Nov 2019 03:06:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573355196; bh=5x+LmrqeEnbeK59deb9In/L3b8XEmOiclhXJ0kY79ls=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hyTiPEkaK5Kjvg3GzDgWiMdDX0YATt31IaH89/VSaW9ScfP/ku131o/ce0v+7T4Q2 m/6DolqPsi7Ng57uXQCZBby/phQ8F6A74RyN2ygybKQSOLL0u/MK1ZZt3xUDEphesN Lhu6ZWiZ42BqKt/GjflIRfXStDAQslD5X03DHlaE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727264AbfKJDG1 (ORCPT ); Sat, 9 Nov 2019 22:06:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:48138 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727399AbfKJCpv (ORCPT ); Sat, 9 Nov 2019 21:45:51 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1EEF8222C5; Sun, 10 Nov 2019 02:45:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573353950; bh=5x+LmrqeEnbeK59deb9In/L3b8XEmOiclhXJ0kY79ls=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=r48/ujtOM1IOFBVZEGYIh1MSi6hLUHQPjbcFQqqRIKVzXs0+w8EGwIHKY4CKiL5FR vRUn2NME5/ZQkka8jFQB/HYaZwSw1ya9QmTd7i1IWu7cNZqe312NHoW+tDKlgpqNdg 8dWfYpIebnAr50n9fSWw5s+XtgpMRFY0RB3p/mNI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Corey Minyard , Sasha Levin Subject: [PATCH AUTOSEL 4.14 008/109] ipmi:dmi: Ignore IPMI SMBIOS entries with a zero base address Date: Sat, 9 Nov 2019 21:44:00 -0500 Message-Id: <20191110024541.31567-8-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191110024541.31567-1-sashal@kernel.org> References: <20191110024541.31567-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Corey Minyard [ Upstream commit 1574608f5f4204440d6d9f52b971aba967664764 ] Looking at logs from systems all over the place, it looks like tons of broken systems exist that set the base address to zero. I can only guess that is some sort of non-standard idea to mark the interface as not being present. It can't be zero, anyway, so just complain and ignore it. Signed-off-by: Corey Minyard Signed-off-by: Sasha Levin --- drivers/char/ipmi/ipmi_dmi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/char/ipmi/ipmi_dmi.c b/drivers/char/ipmi/ipmi_dmi.c index c3a23ec3e76f7..a37d9794170cc 100644 --- a/drivers/char/ipmi/ipmi_dmi.c +++ b/drivers/char/ipmi/ipmi_dmi.c @@ -197,6 +197,10 @@ static void __init dmi_decode_ipmi(const struct dmi_header *dm) slave_addr = data[DMI_IPMI_SLAVEADDR]; memcpy(&base_addr, data + DMI_IPMI_ADDR, sizeof(unsigned long)); + if (!base_addr) { + pr_err("Base address is zero, assuming no IPMI interface\n"); + return; + } if (len >= DMI_IPMI_VER2_LENGTH) { if (type == IPMI_DMI_TYPE_SSIF) { offset = 0; -- 2.20.1