From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: jbeulich@suse.com, tglx@linutronix.de, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] x86/apic/32: Avoid bogus LDR warnings" failed to apply to 4.14-stable tree
Date: Mon, 11 Nov 2019 09:14:44 -0500 [thread overview]
Message-ID: <20191111141444.GD8496@sasha-vm> (raw)
In-Reply-To: <15734537989102@kroah.com>
On Mon, Nov 11, 2019 at 07:29:58AM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.14-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From fe6f85ca121e9c74e7490fe66b0c5aae38e332c3 Mon Sep 17 00:00:00 2001
>From: Jan Beulich <jbeulich@suse.com>
>Date: Tue, 29 Oct 2019 10:34:19 +0100
>Subject: [PATCH] x86/apic/32: Avoid bogus LDR warnings
>
>The removal of the LDR initialization in the bigsmp_32 APIC code unearthed
>a problem in setup_local_APIC().
>
>The code checks unconditionally for a mismatch of the logical APIC id by
>comparing the early APIC id which was initialized in get_smp_config() with
>the actual LDR value in the APIC.
>
>Due to the removal of the bogus LDR initialization the check now can
>trigger on bigsmp_32 APIC systems emitting a warning for every booting
>CPU. This is of course a false positive because the APIC is not using
>logical destination mode.
>
>Restrict the check and the possibly resulting fixup to systems which are
>actually using the APIC in logical destination mode.
>
>[ tglx: Massaged changelog and added Cc stable ]
>
>Fixes: bae3a8d3308 ("x86/apic: Do not initialize LDR and DFR for bigsmp")
>Signed-off-by: Jan Beulich <jbeulich@suse.com>
>Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>Cc: stable@vger.kernel.org
>Link: https://lkml.kernel.org/r/666d8f91-b5a8-1afd-7add-821e72a35f03@suse.com
I've queued these additional patches as dependencies on 4.9 and 4.14:
9d4730880a6d3 ("x86/apic: Drop logical_smp_processor_id() inline")
30769b576ce79 ("x86/apic: Move pending interrupt check code into it's
own function")
--
Thanks,
Sasha
prev parent reply other threads:[~2019-11-11 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 6:29 FAILED: patch "[PATCH] x86/apic/32: Avoid bogus LDR warnings" failed to apply to 4.14-stable tree gregkh
2019-11-11 14:14 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111141444.GD8496@sasha-vm \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbeulich@suse.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).