From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAD97C43331 for ; Mon, 11 Nov 2019 18:42:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C505B21783 for ; Mon, 11 Nov 2019 18:42:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573497737; bh=b0+wHfdxK6blSJTOX65f88M9L+pTzgIeBUoYaIac8RU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yo72sdUFK/Ds0dnwix9RHp+ZrH4I4NCUkCW87AWgi2L9IzQKNTfyMJG7/dt6NApZB 0SoQgq+9vbrezWJ4Rz8ya44eq9PtZPz5pbSgkoDAt6UXukF06RUQXFqeMi1v0kBFD8 ptz3+43GdIytJ1+JI/RNaCrGu7ySCKZn05vTfunc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729487AbfKKSmK (ORCPT ); Mon, 11 Nov 2019 13:42:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:33366 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729482AbfKKSmK (ORCPT ); Mon, 11 Nov 2019 13:42:10 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 122E42067B; Mon, 11 Nov 2019 18:42:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573497729; bh=b0+wHfdxK6blSJTOX65f88M9L+pTzgIeBUoYaIac8RU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pq/toKoazE6JEdtdYQOeQ/KbTYThMjzCbFYCcKtCDw046mv9TFGi/Iv6fO91xoZZX 4DQOqplDe33F66awLMM9sJUWNGA5w5tfn2UIw21E4Ls6e1s7foVoox4fLsoLKJ0jY2 hZHSlcFJLmFIqHdoOdJvHq4UJvsVxkVd272Db4Mo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pan Bian , "David S. Miller" Subject: [PATCH 4.19 008/125] NFC: fdp: fix incorrect free object Date: Mon, 11 Nov 2019 19:27:27 +0100 Message-Id: <20191111181440.573470553@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191111181438.945353076@linuxfoundation.org> References: <20191111181438.945353076@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Pan Bian [ Upstream commit 517ce4e93368938b204451285e53014549804868 ] The address of fw_vsc_cfg is on stack. Releasing it with devm_kfree() is incorrect, which may result in a system crash or other security impacts. The expected object to free is *fw_vsc_cfg. Signed-off-by: Pan Bian Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/nfc/fdp/i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/nfc/fdp/i2c.c +++ b/drivers/nfc/fdp/i2c.c @@ -267,7 +267,7 @@ static void fdp_nci_i2c_read_device_prop *fw_vsc_cfg, len); if (r) { - devm_kfree(dev, fw_vsc_cfg); + devm_kfree(dev, *fw_vsc_cfg); goto vsc_read_err; } } else {