From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EB1DC17441 for ; Mon, 11 Nov 2019 19:00:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0EB1D21655 for ; Mon, 11 Nov 2019 19:00:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573498800; bh=2FsLtqLhiS99k5pYtrl0YkqcXm3pKpNcJ8wumBrs2j0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=etNBJsYY/NU+koPT96k2Dv86TWXzTdqjqBscqcjLA6ng7RHsJW23IAQ9Cyh8BblAb J86BTwGKaOlBeHoDKRZjqvjnSHeYb+qitscIwsctZnO7HdZorV5UjfNcVJYb5CM2// k1N56fwY0fVzUcC3hv+OJ8nDziKxoM5Z26nwKFu8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730596AbfKKSzF (ORCPT ); Mon, 11 Nov 2019 13:55:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:51718 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729901AbfKKSzE (ORCPT ); Mon, 11 Nov 2019 13:55:04 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 68BA12173B; Mon, 11 Nov 2019 18:55:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573498504; bh=2FsLtqLhiS99k5pYtrl0YkqcXm3pKpNcJ8wumBrs2j0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gw/CTandKyeVLC8vLmoVnsNqf1HhHuCfxEv8kIbcPfMlffQkxSFKoSwibDry0+IrT ARVt0fTiKXpVsRtW7sC9WeJW2i3xx5MB96mpAZb4c4zh1w7CK2QAu9k/Czvc9p13TB SE58YwdE6oZlaReOWjPE2M8AkpWrqM4NCzlLZXHk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, James Smart , Daniel Wagner , James Smart , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.3 111/193] scsi: lpfc: Check queue pointer before use Date: Mon, 11 Nov 2019 19:28:13 +0100 Message-Id: <20191111181509.301623127@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191111181459.850623879@linuxfoundation.org> References: <20191111181459.850623879@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Daniel Wagner [ Upstream commit 535fb49e730a6fe1e9f11af4ae67ef4228ff4287 ] The queue pointer might not be valid. The rest of the code checks the pointer before accessing it. lpfc_sli4_process_missed_mbox_completions is the only place where the check is missing. Fixes: 657add4e5e15 ("scsi: lpfc: Fix poor use of hardware queues if fewer irq vectors") Cc: James Smart Link: https://lore.kernel.org/r/20191018162111.8798-1-dwagner@suse.de Signed-off-by: Daniel Wagner Reviewed-by: James Smart Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/lpfc/lpfc_sli.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index f9e6a135d6565..c7027ecd4d19e 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -7898,7 +7898,7 @@ lpfc_sli4_process_missed_mbox_completions(struct lpfc_hba *phba) if (sli4_hba->hdwq) { for (eqidx = 0; eqidx < phba->cfg_irq_chann; eqidx++) { eq = phba->sli4_hba.hba_eq_hdl[eqidx].eq; - if (eq->queue_id == sli4_hba->mbx_cq->assoc_qid) { + if (eq && eq->queue_id == sli4_hba->mbx_cq->assoc_qid) { fpeq = eq; break; } -- 2.20.1