From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0F42C43215 for ; Tue, 19 Nov 2019 05:59:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BEB0720872 for ; Tue, 19 Nov 2019 05:59:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574143197; bh=oeHpWnG6wYyTw+fo0e/fFTR7t5jTwjvQijXwsb60cU0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0+sULjwu2HemwX68tEHnlEvr3/lXEQTVWLOAyy9SHtzJ+1E6CKJVrNm9K4b7xrezx SHC2XXYuuPpeGhSghzkgNxSclxaE0cBm7JYEs8kPSeWKj1xad5gOoosmnQvgFmuaLg zRZo/rYl1HIacxCJnEkyATUDdGxfpBaqnKKHy79A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728562AbfKSFqf (ORCPT ); Tue, 19 Nov 2019 00:46:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:42706 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730839AbfKSFqf (ORCPT ); Tue, 19 Nov 2019 00:46:35 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 779D92075E; Tue, 19 Nov 2019 05:46:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142394; bh=oeHpWnG6wYyTw+fo0e/fFTR7t5jTwjvQijXwsb60cU0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aAFLa7SdIIg5tQlDn1jM1nZGdnWfqVJ3n99RMynnm54vSFHpBlDomkKmvKIqsw8da 8KbvsdCZKp6/0z9uaPhvCFPujk4NWvDwvpL/IJTnpRoeJpbKX1mtyuq4wSiesleDJK UYDZ7NCOlBA5BXad3CEcQAKWjHQMk2HqHvAPP96A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stefan Wahren , Raghuram Chary Jallipalli , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 066/239] net: lan78xx: Bail out if lan78xx_get_endpoints fails Date: Tue, 19 Nov 2019 06:17:46 +0100 Message-Id: <20191119051312.194413686@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191119051255.850204959@linuxfoundation.org> References: <20191119051255.850204959@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Stefan Wahren [ Upstream commit fa8cd98c06407b5798b927cd7fd14d30f360ed02 ] We need to bail out if lan78xx_get_endpoints() fails, otherwise the result is overwritten. Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet") Signed-off-by: Stefan Wahren Reviewed-by: Raghuram Chary Jallipalli Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/lan78xx.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 78a12d7b96e86..2229284d16f56 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -2818,6 +2818,11 @@ static int lan78xx_bind(struct lan78xx_net *dev, struct usb_interface *intf) int i; ret = lan78xx_get_endpoints(dev, intf); + if (ret) { + netdev_warn(dev->net, "lan78xx_get_endpoints failed: %d\n", + ret); + return ret; + } dev->data[0] = (unsigned long)kzalloc(sizeof(*pdata), GFP_KERNEL); -- 2.20.1