From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5685FC43215 for ; Tue, 19 Nov 2019 05:46:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E4192075E for ; Tue, 19 Nov 2019 05:46:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142401; bh=etxpC8JZZJWPy8F/xgvTzSrSpq2DAsTTtvter5MD1QY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2PTidVo1eXERaZcnJhhNefCNYchW/7pBt58wn76TClN4GOiPMdeQrqSM1MGeUP3IA BekvzEZxIoM83Xi8B+H4IuF5vF4SQ7YDsaEN+WKHVDBpClZ3OGr82OBbNyBHKBG2pW 51frlmIiiaz7yryK2T+gxCDOrzaPQ7h2QafgxILQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730347AbfKSFqk (ORCPT ); Tue, 19 Nov 2019 00:46:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:42762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731128AbfKSFqh (ORCPT ); Tue, 19 Nov 2019 00:46:37 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AC0DA2071B; Tue, 19 Nov 2019 05:46:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142397; bh=etxpC8JZZJWPy8F/xgvTzSrSpq2DAsTTtvter5MD1QY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pLx1MrZ5t3aTthC8KovmwUFutLGWfS2hA2Rbb9ywkRU13oT8GFHglXVilLbfia0dA QuSKyusy7DRUo9c+CDT4dsmN9KVT3UmZItlgYco3mxIw+vbs+IDutjl2NlEo6FOv7P chrBvGylHf0SCEnW3QNEs+m320mCa2JqEwdSbRL0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , Mark Brown , Sasha Levin Subject: [PATCH 4.14 067/239] ASoC: sgtl5000: avoid division by zero if lo_vag is zero Date: Tue, 19 Nov 2019 06:17:47 +0100 Message-Id: <20191119051312.407793060@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191119051255.850204959@linuxfoundation.org> References: <20191119051255.850204959@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Colin Ian King [ Upstream commit 9ab708aef61f5620113269a9d1bdb1543d1207d0 ] In the case where lo_vag <= SGTL5000_LINE_OUT_GND_BASE, lo_vag is set to zero and later vol_quot is computed by dividing by lo_vag causing a division by zero error. Fix this by avoiding a zero division and set vol_quot to zero in this specific case so that the lowest setting for i is correctly set. Signed-off-by: Colin Ian King Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/sgtl5000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 10764c1e854e2..ca8a70ab22a82 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -1314,7 +1314,7 @@ static int sgtl5000_set_power_regs(struct snd_soc_codec *codec) * Searching for a suitable index solving this formula: * idx = 40 * log10(vag_val / lo_cagcntrl) + 15 */ - vol_quot = (vag * 100) / lo_vag; + vol_quot = lo_vag ? (vag * 100) / lo_vag : 0; lo_vol = 0; for (i = 0; i < ARRAY_SIZE(vol_quot_table); i++) { if (vol_quot >= vol_quot_table[i]) -- 2.20.1