From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFD46C43215 for ; Tue, 19 Nov 2019 05:58:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8DD96206DA for ; Tue, 19 Nov 2019 05:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574143125; bh=J6ZEfStz5DT4isXE9ce7olgvh3mbHLrQijoXZCL5OSk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1ypvjNLJFn2ab1Rur0zcG6xhqhy0z8PTnRKs6N28ivNSrRdaXsVBbm9k+XitNUWQV omApwJNmgZ/vjN2f4i5zZS308hPcgfpPueVybJOoEQqEAW3Xo2XI0jbXqSu+f1xnQP oFRI47+61KfaBMz77PaEdiCo/H6JtDoXvKr864Y4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731122AbfKSFsx (ORCPT ); Tue, 19 Nov 2019 00:48:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:45488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731414AbfKSFsw (ORCPT ); Tue, 19 Nov 2019 00:48:52 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 98DD020721; Tue, 19 Nov 2019 05:48:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142532; bh=J6ZEfStz5DT4isXE9ce7olgvh3mbHLrQijoXZCL5OSk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gDK1oibrS2sxO3gEh9Gm36slPM8G8U7SzwY/V7c9iiJ88EtgugGC9iETdrvtvqEnr coxngEL8+UWd5U5PpMj3fbzoOP3aurk7Q0guXEA3AijjJUXc64XBViREEVSTcvq2nd vxvAx/ft6b3u8EIyVUzNwe948HQQll6Sp9m7Tnso= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Cong Wang , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 112/239] llc: avoid blocking in llc_sap_close() Date: Tue, 19 Nov 2019 06:18:32 +0100 Message-Id: <20191119051328.074556262@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191119051255.850204959@linuxfoundation.org> References: <20191119051255.850204959@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Cong Wang [ Upstream commit 9708d2b5b7c648e8e0a40d11e8cea12f6277f33c ] llc_sap_close() is called by llc_sap_put() which could be called in BH context in llc_rcv(). We can't block in BH. There is no reason to block it here, kfree_rcu() should be sufficient. Signed-off-by: Cong Wang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- include/net/llc.h | 1 + net/llc/llc_core.c | 4 +--- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/include/net/llc.h b/include/net/llc.h index 890a87318014d..df282d9b40170 100644 --- a/include/net/llc.h +++ b/include/net/llc.h @@ -66,6 +66,7 @@ struct llc_sap { int sk_count; struct hlist_nulls_head sk_laddr_hash[LLC_SK_LADDR_HASH_ENTRIES]; struct hlist_head sk_dev_hash[LLC_SK_DEV_HASH_ENTRIES]; + struct rcu_head rcu; }; static inline diff --git a/net/llc/llc_core.c b/net/llc/llc_core.c index 260b3dc1b4a2a..64d4bef04e730 100644 --- a/net/llc/llc_core.c +++ b/net/llc/llc_core.c @@ -127,9 +127,7 @@ void llc_sap_close(struct llc_sap *sap) list_del_rcu(&sap->node); spin_unlock_bh(&llc_sap_list_lock); - synchronize_rcu(); - - kfree(sap); + kfree_rcu(sap, rcu); } static struct packet_type llc_packet_type __read_mostly = { -- 2.20.1