From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32D07C432C3 for ; Tue, 19 Nov 2019 05:56:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 026DF222A0 for ; Tue, 19 Nov 2019 05:56:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142967; bh=gFH7RF9kjuycd1v3SceNDYD8T8HQ4LSITu6INg04wGw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=UcUCl13By3hCqI6duutMDlDqguelNhtYOmRN3zL5U7wN1OBM1cagd9FVlStpm0tvj kySDNU/y/Yy3GsCNsHXmSv5gdqUtmdSm6oWwFx034WTI+EAeLvWfBG1+WtNGnHNU0m sqOAEVnjobnh1JE8/FcXWwQ0qO0oHDqh9gVmwoD0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730997AbfKSF4F (ORCPT ); Tue, 19 Nov 2019 00:56:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:52390 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732110AbfKSFyQ (ORCPT ); Tue, 19 Nov 2019 00:54:16 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 500F12084D; Tue, 19 Nov 2019 05:54:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574142855; bh=gFH7RF9kjuycd1v3SceNDYD8T8HQ4LSITu6INg04wGw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cCVGkNe7DHXTZ20TrVoz9X/eoJvLkcaV2RQ/9+tDlRsmV1APSnKTg+m24U+lSB5nr 48dcMPnQs0SFkj5p/BSMRIn5BEu2Vyp6m1GU/1FGvutPopEZKZts0x1gz4BNbZiE5N S5RPzZwX+SWJzUV6vADHo9HO+31aVOgkIdgGRFF4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michael Schmitz , Finn Thain , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.14 224/239] scsi: NCR5380: Check for invalid reselection target Date: Tue, 19 Nov 2019 06:20:24 +0100 Message-Id: <20191119051339.675079350@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191119051255.850204959@linuxfoundation.org> References: <20191119051255.850204959@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Finn Thain [ Upstream commit 7ef55f6744c45e3d7c85a3f74ada39b67ac741dd ] The X3T9.2 specification (draft) says, under "6.1.4.1 RESELECTION", that "the initiator shall not respond to a RESELECTION phase if other than two SCSI ID bits are on the DATA BUS." This issue (too many bits set) has been observed in the wild, so add a check. Tested-by: Michael Schmitz Signed-off-by: Finn Thain Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/NCR5380.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c index 00397e89d652d..a290ec632248e 100644 --- a/drivers/scsi/NCR5380.c +++ b/drivers/scsi/NCR5380.c @@ -2014,6 +2014,11 @@ static void NCR5380_reselect(struct Scsi_Host *instance) NCR5380_write(MODE_REG, MR_BASE); target_mask = NCR5380_read(CURRENT_SCSI_DATA_REG) & ~(hostdata->id_mask); + if (!target_mask || target_mask & (target_mask - 1)) { + shost_printk(KERN_WARNING, instance, + "reselect: bad target_mask 0x%02x\n", target_mask); + return; + } dsprintk(NDEBUG_RESELECTION, instance, "reselect\n"); -- 2.20.1