From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 667AEC43215 for ; Fri, 22 Nov 2019 10:57:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3512D20718 for ; Fri, 22 Nov 2019 10:57:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574420224; bh=1tGftarjUnn0WkDsVLhvxVIToADcwZUnJ117RERnNJE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=EfOcW6QkAYewWXkwm8medDS50gjRHPRyR7D2AaDfpQtu93KANKaEZUFbKDhpgqjOb RqECzjcQNlCPsLTntKrt9Qz1KnbzSIsdb6zaC6iIHfhkWfH1hvPPj7dkWb8I2wqIlV ZkhWfzFVduxClCp0kMVTcBckn+q5+GIvakhSNPl0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729394AbfKVK4q (ORCPT ); Fri, 22 Nov 2019 05:56:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:45000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730348AbfKVK4p (ORCPT ); Fri, 22 Nov 2019 05:56:45 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 86A3120715; Fri, 22 Nov 2019 10:56:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574420205; bh=1tGftarjUnn0WkDsVLhvxVIToADcwZUnJ117RERnNJE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XPu5qOqhG/qqXUkYDNwI50IK1/2YkFqXO+00CoSvNl7m5vwbDb65bGn93YrfgztUQ SOuZwhzywMOWeGsjS+NVHnITxxq5r2E673F8I++v8ez0wduABgjKxKGpo16vmTQjet h8SND3dh9CUPHATknuCV6y5suGDD3PvG5lJojaE8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , "David S. Miller" , Nobuhiro Iwamatsu Subject: [PATCH 4.19 005/220] net: cdc_ncm: Signedness bug in cdc_ncm_set_dgram_size() Date: Fri, 22 Nov 2019 11:26:10 +0100 Message-Id: <20191122100913.071503274@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191122100912.732983531@linuxfoundation.org> References: <20191122100912.732983531@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter commit a56dcc6b455830776899ce3686735f1172e12243 upstream. This code is supposed to test for negative error codes and partial reads, but because sizeof() is size_t (unsigned) type then negative error codes are type promoted to high positive values and the condition doesn't work as expected. Fixes: 332f989a3b00 ("CDC-NCM: handle incomplete transfer of MTU") Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller Signed-off-by: Nobuhiro Iwamatsu Signed-off-by: Greg Kroah-Hartman --- drivers/net/usb/cdc_ncm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/usb/cdc_ncm.c +++ b/drivers/net/usb/cdc_ncm.c @@ -579,7 +579,7 @@ static void cdc_ncm_set_dgram_size(struc err = usbnet_read_cmd(dev, USB_CDC_GET_MAX_DATAGRAM_SIZE, USB_TYPE_CLASS | USB_DIR_IN | USB_RECIP_INTERFACE, 0, iface_no, &max_datagram_size, sizeof(max_datagram_size)); - if (err < sizeof(max_datagram_size)) { + if (err != sizeof(max_datagram_size)) { dev_dbg(&dev->intf->dev, "GET_MAX_DATAGRAM_SIZE failed\n"); goto out; }