From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org, gregkh@google.com, stable@vger.kernel.org
Subject: [PATCH 4.4 5/9] bcache: silence static checker warning
Date: Fri, 22 Nov 2019 10:51:09 +0000 [thread overview]
Message-ID: <20191122105113.11213-5-lee.jones@linaro.org> (raw)
In-Reply-To: <20191122105113.11213-1-lee.jones@linaro.org>
From: Dan Carpenter <dan.carpenter@oracle.com>
[ Upstream commit da22f0eea555baf9b0a84b52afe56db2052cfe8d ]
In olden times, closure_return() used to have a hidden return built in.
We removed the hidden return but forgot to add a new return here. If
"c" were NULL we would oops on the next line, but fortunately "c" is
never NULL. Let's just remove the if statement.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/md/bcache/super.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index e42092146083..58e16a3fb3bd 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1395,9 +1395,6 @@ static void cache_set_flush(struct closure *cl)
struct btree *b;
unsigned i;
- if (!c)
- closure_return(cl);
-
bch_cache_accounting_destroy(&c->accounting);
kobject_put(&c->internal);
--
2.24.0
next prev parent reply other threads:[~2019-11-22 11:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 10:51 [PATCH 4.4 1/9] ARM: 8904/1: skip nomap memblocks while finding the lowmem/highmem boundary Lee Jones
2019-11-22 10:51 ` [PATCH 4.4 2/9] can: dev: can_dellink(): remove return at end of void function Lee Jones
2019-11-22 10:51 ` [PATCH 4.4 3/9] arm64: fix for bad_mode() handler to always result in panic Lee Jones
2019-11-22 10:51 ` [PATCH 4.4 4/9] cpufreq: Skip cpufreq resume if it's not suspended Lee Jones
2019-11-22 10:51 ` Lee Jones [this message]
2019-11-22 10:51 ` [PATCH 4.4 6/9] dm: use blk_set_queue_dying() in __dm_destroy() Lee Jones
2019-11-22 10:51 ` [PATCH 4.4 7/9] mmc: block: Fix tag condition with packed writes Lee Jones
2019-11-22 10:51 ` [PATCH 4.4 8/9] ocfs2: remove ocfs2_is_o2cb_active() Lee Jones
2019-11-22 10:51 ` [PATCH 4.4 9/9] ext4: avoid unnecessary stalls in ext4_evict_inode() Lee Jones
2019-11-22 16:32 ` [PATCH 4.4 1/9] ARM: 8904/1: skip nomap memblocks while finding the lowmem/highmem boundary Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122105113.11213-5-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=gregkh@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox