From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7149EC43215 for ; Fri, 22 Nov 2019 19:52:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D1FD2071F for ; Fri, 22 Nov 2019 19:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574452354; bh=6B6O62VsSmQ9td4bxnHQ2h5Eb0ep/BofIKBLt8ctx7g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=RNX0Rj3GNwGQxXWsues0++T8cSiWhjAFsNZ5MucBg4X1WMLNMXwdF8ywXLM+lxX0b 8LFNXYeGWKk9u3nRRiFpEAEiCLMuYNXW54bf8qCWsZ7sSp2Mm9jGfbmcgSPLnxi3B3 sIiVZ/s5C8MumvFtb6Uf9sOJiC1U0rQeQXTqhwso= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727603AbfKVTtu (ORCPT ); Fri, 22 Nov 2019 14:49:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:50024 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726752AbfKVTtt (ORCPT ); Fri, 22 Nov 2019 14:49:49 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 29C022073B; Fri, 22 Nov 2019 19:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574452188; bh=6B6O62VsSmQ9td4bxnHQ2h5Eb0ep/BofIKBLt8ctx7g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E5qn3zfcvu1yNfb3FB/jJ1MtlXKBKce2oNwu1kOIpWeeFhRBNjNumY8RmAI7m8VK4 69NHGzGUcOpS5b8wrjKop2JeHWhKv+ssVjhFKLeljPTtFSx88CTJzrTS3gj4NPawVu ZgCcQYnwMUfztirqa3pwAieBVIxKG9uYAQUmazdg= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , "David S . Miller" , Sasha Levin , linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 14/21] net: cdc_ncm: Signedness bug in cdc_ncm_set_dgram_size() Date: Fri, 22 Nov 2019 14:49:24 -0500 Message-Id: <20191122194931.24732-14-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191122194931.24732-1-sashal@kernel.org> References: <20191122194931.24732-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter [ Upstream commit a56dcc6b455830776899ce3686735f1172e12243 ] This code is supposed to test for negative error codes and partial reads, but because sizeof() is size_t (unsigned) type then negative error codes are type promoted to high positive values and the condition doesn't work as expected. Fixes: 332f989a3b00 ("CDC-NCM: handle incomplete transfer of MTU") Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/cdc_ncm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index d53b4a41c583a..cb4c9d419bd39 100644 --- a/drivers/net/usb/cdc_ncm.c +++ b/drivers/net/usb/cdc_ncm.c @@ -579,7 +579,7 @@ static void cdc_ncm_set_dgram_size(struct usbnet *dev, int new_size) err = usbnet_read_cmd(dev, USB_CDC_GET_MAX_DATAGRAM_SIZE, USB_TYPE_CLASS | USB_DIR_IN | USB_RECIP_INTERFACE, 0, iface_no, &max_datagram_size, sizeof(max_datagram_size)); - if (err < sizeof(max_datagram_size)) { + if (err != sizeof(max_datagram_size)) { dev_dbg(&dev->intf->dev, "GET_MAX_DATAGRAM_SIZE failed\n"); goto out; } -- 2.20.1